-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP Compatibility: Remove patched imgareaselect
package
#13473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix was introduced in PR#8501 to support for WordPress version < 6.2
AnuragVasanwala
added
Type: Bug
Something isn't working
Group: Media
Group: WordPress
Changes related to WordPress or Gutenberg integration
labels
Oct 9, 2023
Plugin builds for 41a9966 are ready 🛎️!
|
9 tasks
AnuragVasanwala
changed the title
Fix: Remove
Fix: Revert Oct 9, 2023
ImgAreaSelect_Patch
workaround for WP 6.2 min versionImgAreaSelect_Patch
workaround for WP 6.2 min version
swissspidy
changed the title
Fix: Revert
WP Compatibility: Remove patched Oct 10, 2023
ImgAreaSelect_Patch
workaround for WP 6.2 min versionimgareaselect
package
swissspidy
added
Type: Enhancement
New feature or improvement of an existing feature
and removed
Type: Bug
Something isn't working
labels
Oct 10, 2023
9 tasks
Size Change: -3.77 kB (0%) Total Size: 2.75 MB
ℹ️ View Unchanged
|
swissspidy
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Group: Media
Group: WordPress
Changes related to WordPress or Gutenberg integration
Type: Enhancement
New feature or improvement of an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of the PR is to revert the fix introduced in PR #8501 to support for WordPress version < 6.2 for a bug in
imgareaselect
.As we are going to support WordPress 6.2 as min in the upcoming milestone 1.35.0, this fix is no longer needed.
User-facing changes
Not applicable.
Testing Instructions
Please follow testing instruction provided in the PR #8501.
Reviews
Does this PR have a security-related impact?
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Type: XYZ
label to the PRSee #13424