Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WP version requirement to 6.2+ #13424

Closed
9 tasks done
swissspidy opened this issue Jul 13, 2023 · 4 comments · Fixed by #13474 or #13473
Closed
9 tasks done

Bump WP version requirement to 6.2+ #13424

swissspidy opened this issue Jul 13, 2023 · 4 comments · Fixed by #13474 or #13473
Assignees
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Task Tasks which do not involve engineering
Milestone

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Jul 13, 2023

Task Description

Once the majority of our users has updated to 6.3 and usage of 6.1 has dropped, we can look at increasing our minimum WordPress version requirement again. Maybe around the 6.4 release. This is just a tracking ticket for now.

Such a bump usually allows us to remove some technical debt both on the PHP and JS side of the plugin.

Previously:

Resources:

Things that stand out:

Tasks include:

  • Bump in readme.txt
  • Bump in web-stories.php (twice)
  • Bump in tests/phpstan/bootstrap.php for consistency
  • Update minimum_supported_wp_version in phpcs.xml.dist
  • Run e2e tests against 6.2 instead of 6.1
  • Run unit tests against 6.2 instead of 6.1
  • Re-evaluate PHPUnit matrix and composer dependencies if necessary
  • Revert 6749017
  • Remove packages/imgareaselect package
@swissspidy swissspidy added Type: Task Tasks which do not involve engineering Group: WordPress Changes related to WordPress or Gutenberg integration Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ P3 Nice to have labels Jul 13, 2023
@swissspidy

This comment was marked as resolved.

@swissspidy
Copy link
Collaborator Author

I don't see a use case for the HTML API in our code base. While we do have some places where we manipulate HTML strings, like in the Cross_Origin_Isolation class, doing so with str_replace the way we do it is much much faster than using the WP_HTML_Tag_Processor. So no change needed there.

@AnuragVasanwala
Copy link
Collaborator

AnuragVasanwala commented Oct 9, 2023

@swissspidy I have created two PRs which addresses following tasks of this issue:

  • Bump in readme.txt
  • Bump in web-stories.php (twice)
  • Bump in tests/phpstan/bootstrap.php for consistency
  • Update minimum_supported_wp_version in phpcs.xml.dist
  • Run e2e tests against 6.2 instead of 6.1
  • Run unit tests against 6.2 instead of 6.1
  • Re-evaluate PHPUnit matrix and composer dependencies if necessary
  • Revert 6749017
  • Remove packages/imgareaselect package

#13474 bumps WP min version to 6.2 and #13473 removes imgareaselect patch. Once these PRs are ready, we can start running e2e and unit tests against 6.2.

@swissspidy
Copy link
Collaborator Author

We can and should change the e2e/unit test matrix before #13474, as otherwise tests in that PR fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Task Tasks which do not involve engineering
Projects
None yet
2 participants