-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WordPress 6.3 Compatibility #13427
WordPress 6.3 Compatibility #13427
Conversation
Plugin builds for b976556 are ready 🛎️!
|
Size Change: 0 B Total Size: 2.74 MB ℹ️ View Unchanged
|
@AnuragVasanwala FYI this will fix the e2e tests which are currently failing elsewhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few queries otherwise, LGTM ✅
- Should we remove this class?
web-stories-wp/includes/Admin/ImgAreaSelect_Patch.php
Lines 37 to 43 in b976556
/** * Class ImgAreaSelect_Patch * * TODO Remove this workaround once WP 6.2 is min version. See https://github.com/WordPress/wordpress-develop/commit/ef0c1d1dd28f13bbe6b39447fb5fbc36edf7df80 */ class ImgAreaSelect_Patch implements Conditional, Service, Registerable { /** - Should we look into this to upgrade React to v18?
web-stories-wp/packages/e2e-tests/src/config/bootstrap.js
Lines 123 to 125 in b976556
// Needed because the tinymce package is not yet using React 18. // TODO: Migrate & remove once WordPress 6.2 is minimum. 'Warning: ReactDOM.render is no longer supported in React 18',
The minimum is still WordPress 6.1, not 6.2. These two need to get addressed as part of #13424 |
Context
WP 6.3 is out soon
Summary
See individual commits for details.
Relevant Technical Choices
N/A
To-do
User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZ
label to the PRFixes #13259