Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requests resources to examples/example-app.yaml #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added requests resources to examples/example-app.yaml #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions examples/example-app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ spec:
values:
- linux
containers:
# Instrumentation source: https://github.com/nilebox/prometheus-example-app
- image: nilebox/prometheus-example-app@sha256:dab60d038c5d6915af5bcbe5f0279a22b95a8c8be254153e22d7cd81b21b84c5
name: prom-example
ports:
Expand All @@ -52,3 +53,7 @@ spec:
- "/main"
- "--process-metrics"
- "--go-metrics"
resources:
requests:
cpu: 100m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is significantly higher than other applications we have. Is the example app really more resource intensive than prometheus?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, but not sure if it matters as long as it's not something ridiculous by default (500m)

memory: 100Mi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We give our operator 32M. Did you check actual usage?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, will check, but I don't think that's important as long as it's not 2GBi (default on my autopilot cluster)