-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added requests resources to examples/example-app.yaml #537
base: main
Are you sure you want to change the base?
Conversation
Related to #536 Signed-off-by: bwplotka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some comments but I know we want to improve the example app so I'm not going to be too picky here.
@@ -52,3 +53,7 @@ spec: | |||
- "/main" | |||
- "--process-metrics" | |||
- "--go-metrics" | |||
resources: | |||
requests: | |||
cpu: 100m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is significantly higher than other applications we have. Is the example app really more resource intensive than prometheus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, but not sure if it matters as long as it's not something ridiculous by default (500m)
resources: | ||
requests: | ||
cpu: 100m | ||
memory: 100Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. We give our operator 32M
. Did you check actual usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, will check, but I don't think that's important as long as it's not 2GBi (default on my autopilot cluster)
Related to #536