Removing .coveralls.yml to fix #173 #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2018
|
Hmm this may not work as-is due to the docker container being the way, please see the issue for more up-to-date information as I look into this |
|
Updated which should now run coveralls correctly outside of docker It is currently undetermined if this will correctly produce coverage information. |
|
I'm not sure if this is now correctly calculating coverage, it still seems to be at 0% |
to be run twice, ctest and make do not.
|
@wow2006 I want to close this without merging. Any objections? |
|
Hmm. I think we should cherry pick e9559b3 first. If that works out we can figure out if and how we remove the coveralls file from the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.