-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.coveralls.yml should not be public #173
Comments
#174 sent You may also want to make sure you regenerate you REPO_TOKEN on coveralls.io |
Hmmm this might be complicated by it running within Docker, that may meant the environment isn't setup correctly. See lemurheavy/coveralls-public#997 for other projects dealing with this |
I'm working on a fix for this to run the tests within docker and run cpp-coveralls outside of docker, so that we can remove the .coveralls.yml file |
I have updated the PR to move the cpp-coveralls call to run outside the docker container Something about your cmake infrastructure requires it to be run twice before it generates any gcda/gcno files See eddyxu/cpp-coveralls#111 (comment) for more details |
.coveralls.yml is only needed for coveralls.io if you are using travis-ci.com (commercial travis for private repos).
You are using a public github repo, and so your .coveralls.yml is PUBLIC.
That REPO_TOKEN is meant to be a secret, by exposing it you allow anyone to write data to your coveralls.io.
If you remove .coveralls.yml then your results can still be written from travis-ci.org to coveralls.io as long as they both have access via your github account.
I will create a PR to fix this.
For more information please see
lemurheavy/coveralls-public#208
The text was updated successfully, but these errors were encountered: