Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make None colum in Fuels_data optional #720

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Jun 26, 2024

Description

Fix TDR to load Fuels_data.csv even without a None column.

What type of PR is this? (check all applicable)

  • Bug Fix

Related Tickets & Documents

Addresses #552

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

By running any example case with TimeDomainReduction: 1 and without a None column in the Fuels_data.csv input file.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@lbonaldo lbonaldo requested a review from sambuddhac June 26, 2024 22:33
@lbonaldo lbonaldo added this to the v0.4.1 milestone Jun 28, 2024
Copy link
Collaborator

@sambuddhac sambuddhac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR !!! Very logical

@lbonaldo lbonaldo force-pushed the 552-tdr-requires-none-column-in-fuels_data branch from 17dd5c0 to 91e26f7 Compare July 1, 2024 18:18
@lbonaldo lbonaldo merged commit dd4f77f into develop Jul 1, 2024
9 checks passed
@lbonaldo lbonaldo deleted the 552-tdr-requires-none-column-in-fuels_data branch July 1, 2024 18:26
@lbonaldo
Copy link
Collaborator Author

lbonaldo commented Jul 1, 2024

Thanks @sambuddhac!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants