Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDR requires None column in Fuels_data #552

Closed
gmantegna opened this issue Sep 21, 2023 · 3 comments
Closed

TDR requires None column in Fuels_data #552

gmantegna opened this issue Sep 21, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gmantegna
Copy link
Collaborator

Currently, the TDR algorithm throws an error if Fuels_data.csv does not have a None column (for resources that do not use fuel). This should not be required, as GenX itself does not require this column.

cc @cfe316

@cfe316
Copy link
Collaborator

cfe316 commented Sep 26, 2023

@lbonaldo Presumably after loading it from the csv file, TDR only interacts with Fuels_data as a dataframe. We could abstract this to separate the steps of

  1. Load raw data from a file
  2. Preprocess data, i.e. add a None column
  3. (optionally) parse to separate the time series itself from the co2-per-mmbtu numbers.
  4. Present the data to the client function.

@lbonaldo
Copy link
Collaborator

Yes, I think we should have that kind of abstraction for all the inputs. Let me work on that.

@JesseJenkins JesseJenkins added the enhancement New feature or request label Jan 8, 2024
@lbonaldo lbonaldo added this to the v0.4.1 milestone Jun 20, 2024
@lbonaldo
Copy link
Collaborator

lbonaldo commented Jul 3, 2024

#720 fixed this issue on develop.

@lbonaldo lbonaldo closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants