[Debt] Refactors tests to remove Pool Operator, Request Responder, and Community Manager roles

api/database/factories/UserFactory.php

@@ -296,49 +296,6 @@ public function asApplicant()
         });
     }
 
-    /**
-     * Attach the request responder role to a user after creation.
-     *
-     * @return $this
-     */
-    public function asRequestResponder()
-    {
-        return $this->afterCreating(function (User $user) {
-            $user->addRole('request_responder');
-        });
-    }
-
-    /**
-     * Attach the pool operator role to a user after creation.
-     *
-     * @param  string|array  $team  Name of the team or teams to attach the role to
-     * @return $this
-     */
-    public function asPoolOperator(string|array $team)
-    {
-        return $this->afterCreating(function (User $user) use ($team) {
-            if (is_array($team)) {
-                foreach ($team as $singleTeam) {
-                    $user->addRole('pool_operator', $singleTeam);
-                }
-            } else {
-                $user->addRole('pool_operator', $team);
-            }
-        });
-    }
-
-    /**
-     * Attach the Community Manager role to a user after creation.
-     *
-     * @return $this
-     */
-    public function asCommunityManager()
-    {
-        return $this->afterCreating(function (User $user) {
-            $user->addRole('community_manager');
-        });
-    }
-
     /**
      * Attach the admin role to a user after creation.
      *

api/database/seeders/UserTestSeeder.php

@@ -26,11 +26,8 @@ public function run()
         // shared auth users for testing
         User::factory()
             ->asApplicant()
-            ->asRequestResponder()
-            ->asCommunityManager()
             ->asCommunityAdmin([$digitalCommunityId, $atipCommunityId])
             ->asAdmin()
-            ->asPoolOperator(['digital-community-management', 'office-of-indigenous-initiatives'])
             ->withSkillsAndExperiences()
             ->asGovEmployee()
             ->create([
@@ -52,42 +49,6 @@ public function run()
                 'sub' => '[email protected]',
             ]);
 
-        User::factory()
-            ->asApplicant()
-            ->asCommunityManager()
-            ->withSkillsAndExperiences()
-            ->asGovEmployee()
-            ->create([
-                'first_name' => 'Darcy',
-                'last_name' => 'Hussein',
-                'email' => '[email protected]',
-                'sub' => '[email protected]',
-            ]);
-
-        User::factory()
-            ->asApplicant()
-            ->asRequestResponder()
-            ->withSkillsAndExperiences()
-            ->asGovEmployee()
-            ->create([
-                'first_name' => 'Denver',
-                'last_name' => 'Reagan',
-                'email' => '[email protected]',
-                'sub' => '[email protected]',
-            ]);
-
-        User::factory()
-            ->asApplicant()
-            ->asPoolOperator(['digital-community-management', 'office-of-indigenous-initiatives'])
-            ->withSkillsAndExperiences()
-            ->asGovEmployee()
-            ->create([
-                'first_name' => 'Fang',
-                'last_name' => 'Dupont',
-                'email' => '[email protected]',
-                'sub' => '[email protected]',
-            ]);
-
         User::factory()
             ->asApplicant()
             ->withSkillsAndExperiences()

api/tests/Feature/ActivityLogTest.php

@@ -41,10 +41,10 @@ protected function setUp(): void
                 'email' => '[email protected]',
                 'sub' => '[email protected]',
             ]);
-
+        $community = Community::factory()->create(['name' => 'test-community']);
         $this->adminUser = User::factory()
             ->asApplicant()
-            ->asRequestResponder()
+            ->asCommunityRecruiter($community->id)
             ->asAdmin()
             ->create([
                 'email' => '[email protected]',

api/tests/Feature/ApplicantFilterTest.php

@@ -51,7 +51,6 @@ protected function setUp(): void
         // Create super user we run tests as
         // Note: this extra user does change the results of a couple queries
         $this->adminUser = User::factory()
-            ->asRequestResponder()
             ->asAdmin()
             ->create([
                 'email' => '[email protected]',

api/tests/Feature/ApplicantTest.php

@@ -47,7 +47,6 @@ protected function setUp(): void
 
         $this->adminUser = User::factory()
             ->asApplicant()
-            ->asRequestResponder()
             ->asAdmin()
             ->create([
                 'email' => '[email protected]',

api/tests/Feature/AssessmentResultTest.php

@@ -10,11 +10,11 @@
 use App\Facades\Notify;
 use App\Models\AssessmentResult;
 use App\Models\AssessmentStep;
+use App\Models\Community;
 use App\Models\Pool;
 use App\Models\PoolCandidate;
 use App\Models\PoolSkill;
 use App\Models\Skill;
-use App\Models\Team;
 use App\Models\User;
 use Database\Seeders\RolePermissionSeeder;
 use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -33,9 +33,9 @@ class AssessmentResultTest extends TestCase
     use RefreshesSchemaCache;
     use UsesProtectedGraphqlEndpoint;
 
-    protected $teamUser;
+    protected $communityUser;
 
-    protected $team;
+    protected $community;
 
     protected $pool;
 
@@ -45,16 +45,16 @@ protected function setUp(): void
         Notify::spy(); // don't send any notifications
         $this->seed(RolePermissionSeeder::class);
         $this->bootRefreshesSchemaCache();
-        $this->team = Team::factory()->create();
+        $this->community = Community::factory()->create(['name' => 'test-community']);
         $this->pool = Pool::factory()->create([
-            'team_id' => $this->team->id,
+            'community_id' => $this->community->id,
         ]);
-        $this->teamUser = User::factory()
+        $this->communityUser = User::factory()
             ->asApplicant()
-            ->asPoolOperator($this->team->name)
+            ->asProcessOperator($this->pool->id)
             ->create([
-                'email' => 'team[email protected]',
-                'sub' => 'team[email protected]',
+                'email' => 'community[email protected]',
+                'sub' => 'community[email protected]',
             ]);
     }
 
@@ -119,7 +119,7 @@ public function testCreatingAssessmentResult(): void
         $poolSkillModel = PoolSkill::first();
 
         // can create education assessment result without pool skill
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [
@@ -142,7 +142,7 @@ public function testCreatingAssessmentResult(): void
             ]);
 
         // can create skill assessment result with pool skill
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [
@@ -178,7 +178,7 @@ public function testUpdatingAssessmentResult(): void
             'pool_id' => $this->pool->id,
         ]);
 
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [
@@ -193,7 +193,7 @@ public function testUpdatingAssessmentResult(): void
 
         $assessmentResult = AssessmentResult::first();
 
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->updateAssessmentResult,
                 [
@@ -225,7 +225,7 @@ public function testDeletingAssessmentResult(): void
             'pool_id' => $this->pool->id,
         ]);
 
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [
@@ -239,7 +239,7 @@ public function testDeletingAssessmentResult(): void
 
         $assessmentResult = AssessmentResult::first();
 
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->deleteAssessmentResult,
                 [
@@ -274,7 +274,7 @@ public function testAssessmentResultPoolValidation(): void
         $randomPoolSkillModel = PoolSkill::first(); // filled when calling pool factory above, this happens when calling it after skills seeded
 
         // trying combinations of pools and assert they fail, with and without pool skill
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [
@@ -285,7 +285,7 @@ public function testAssessmentResultPoolValidation(): void
                 ]
             )
             ->assertGraphQLValidationError('createAssessmentResult.assessmentStepId', 'AssessmentResultReferencesMultiplePools');
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [
@@ -296,7 +296,7 @@ public function testAssessmentResultPoolValidation(): void
                 ]
             )
             ->assertGraphQLValidationError('createAssessmentResult.assessmentStepId', 'AssessmentResultReferencesMultiplePools');
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [
@@ -310,7 +310,7 @@ public function testAssessmentResultPoolValidation(): void
             ->assertGraphQLValidationError('createAssessmentResult.assessmentStepId', 'AssessmentResultReferencesMultiplePools');
 
         // success when all three reference one pool
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [
@@ -341,7 +341,7 @@ public function testAssessmentResultUpdatingValidation(): void
         ]);
         $poolSkillModel = PoolSkill::first();
 
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [
@@ -360,7 +360,7 @@ public function testAssessmentResultUpdatingValidation(): void
 
         // assert validation blocks some update combinations
         // cannot have skill type with education justifications, validation draws from saved model
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->updateAssessmentResult,
                 [
@@ -373,7 +373,7 @@ public function testAssessmentResultUpdatingValidation(): void
             ->assertGraphQLValidationError('updateAssessmentResult.justifications', 'EducationJustificationsForSkillAssessment');
 
         // cannot have skill decision level for unsuccessful, input changes it from successful
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->updateAssessmentResult,
                 [
@@ -398,7 +398,7 @@ public function testSkillAssessmentRequiresSkill(): void
             'pool_id' => $this->pool->id,
         ]);
 
-        $this->actingAs($this->teamUser, 'api')
+        $this->actingAs($this->communityUser, 'api')
             ->graphQL(
                 $this->createAssessmentResult,
                 [