[Debt] Refactors tests to remove Pool Operator, Request Responder, and Community Manager roles #12530
Conversation
| @@ -1016,6 +989,7 @@ public function testUpdatePoolCandidateClaimVerificationValidation(): void | |||
| */ | |||
| public function testManualStatusUpdatesTimestamps($status, $timestamp) | |||
| { | |||
| $this->markTestSkipped('Only a pool operator can update applicationStatus.'); | |||
There was a problem hiding this comment.
I marked this test as skipped because pool operator is being removed. Should the test be removed altogether?
There was a problem hiding this comment.
currently ProcessOperators are updating candidate status upto Qualified or Disqualified.
But they can't place the candidates.
Is it possible to update the test to verify that? If this has been handled already leave it. If not, I would suggest verifying
- verify ProcessOperator can update status manually to ScreenedIn
- verify ProcessOperator can't update status manually to any of the placed statuses
There was a problem hiding this comment.
So @brindasasi is correct that ProcessOperators can now use the manual update, for certain statuses. So can Community Admins and Community Recruiters. This is new functionality, since #12494.
I don't think we need a second test for placing. #12494 already added a test, PoolCandidateUpdateTest.testManualStatusUpdatePolicy, to ensure Qualifying and Screening are treated differently. The test here is meant to test the timestamp update, not test permissions.
There was a problem hiding this comment.
@mnigh if we have the policy test already we don't need that testManualStatusPlacedUpdatesTimestamps test. Could you remove that ? With that it is good to be merged in.
There was a problem hiding this comment.
@brindasasi an update:
@tristan-orourke had another look and requested to: replace processOperatorUser with communityRecruiterUser; Re-add Placed statuses.
There was a problem hiding this comment.
I took a look and it seems fine. I think @tristan-orourke (or someone else who is confident) should take a look at the comments you made about skipped tests before any approval.
…alStatusPlacedUpdatesTimestamps
🤖 Resolves #12300.
👋 Introduction
This PR refactors tests to remove Pool Operator, Request Responder, and Community Manager roles.
🧪 Testing