Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Add context to dashboard page titles #12397

Merged
merged 4 commits into from
Jan 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/playwright/tests/admin/auth.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ test.describe("Login", () => {
await appPage.waitForGraphqlResponse("AdminDashboard_Query");
await expect(
appPage.page.getByRole("heading", {
name: /welcome back, dale monroe/i,
name: /welcome back/i,
}),
).toBeVisible();
});
Expand Down
2 changes: 1 addition & 1 deletion apps/playwright/tests/login-logout.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ test.describe("Login and logout", () => {
// confirm login in first page context
await expect(
pageOne.getByRole("heading", {
name: "Welcome back, Gul",
name: /welcome back/i,
level: 1,
}),
).toBeVisible();
Expand Down
16 changes: 12 additions & 4 deletions apps/web/src/lang/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,10 @@
"defaultMessage": "Apprentissage en cours d’emploi",
"description": "Experience requirement, On the job."
},
"2FrqUn": {
"defaultMessage": "Bon retour<hidden> sur votre tableau de bord de la collectivité</hidden>, {name}",
"description": "Title for community dashboard on the talent cloud admin portal."
},
"2HGCCF": {
"defaultMessage": "Nous utilisons également cette information pour vous offrir une expérience plus contextualisée, y compris des recommandations de possibilités fondées sur votre situation de l'emploi, votre classification, et plus encore.",
"description": "Message after main heading in employee information page - paragraph 2."
Expand Down Expand Up @@ -7706,6 +7710,10 @@
"defaultMessage": "<strong>Veuillez sélectionner un niveau approprié de maîtrise de la deuxième langue sur la base des définitions fournies.</strong>",
"description": "Text requesting language levels given from bilingual evaluation in language information form"
},
"bw4CAS": {
"defaultMessage": "Bon retour<hidden> sur votre tableau de bord de la candidate ou du candidat</hidden>, {name}",
"description": "Title for applicant dashboard on the talent cloud admin portal."
},
"bwoJyk": {
"defaultMessage": "Informations sur la possibilité de formation",
"description": "Heading for the opportunity form information section"
Expand Down Expand Up @@ -9682,10 +9690,6 @@
"defaultMessage": "Évaluer",
"description": "Talent portal strategy item 3 heading"
},
"lIwJp4": {
"defaultMessage": "Bon retour, {name}",
"description": "Title for dashboard on the talent cloud admin portal."
},
"lKoKu0": {
"defaultMessage": "42 postes de cadres supérieurs et autres postes de dirigeants ont été pourvus au cours de cet exercice, ce qui a permis de doubler les affectations réalisées au cours de l’exercice financier précédent (2022-2023) et de promouvoir la gestion des talents numériques. Veuillez prendre note que les talents numériques sont ciblés lors des tables rondes annuelles interministérielles sur la gestion des talents.",
"description": "Description of executive referral services"
Expand Down Expand Up @@ -11402,6 +11406,10 @@
"defaultMessage": "Vise à lancer le programme au début de 2024.",
"description": "Talent portal strategy item 4 content"
},
"utS0s1": {
"defaultMessage": "Bon retour<hidden> sur votre tableau de bord de l'administrateur</hidden>, {name}",
"description": "Title for admin dashboard on the talent cloud admin portal."
},
"utl6O/": {
"defaultMessage": "Gérer le recrutement {title}",
"description": "Link text to direct a user to the recruitment section on the career timeline page"
Expand Down
7 changes: 4 additions & 3 deletions apps/web/src/pages/AdminDashboardPage/AdminDashboardPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,11 @@ export const DashboardPage = ({ currentUser }: DashboardPageProps) => {
<Hero
title={intl.formatMessage(
{
defaultMessage: "Welcome back, {name}",
id: "lIwJp4",
defaultMessage:
"Welcome back<hidden> to your admin dashboard</hidden>, {name}",
id: "utS0s1",
description:
"Title for dashboard on the talent cloud admin portal.",
"Title for admin dashboard on the talent cloud admin portal.",
},
{
name: currentUser
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ export const DashboardPage = ({ currentUser }: DashboardPageProps) => {
<Hero
title={intl.formatMessage(
{
defaultMessage: "Welcome back, {name}",
id: "lIwJp4",
defaultMessage:
"Welcome back<hidden> to your applicant dashboard</hidden>, {name}",
id: "bw4CAS",
description:
"Title for dashboard on the talent cloud admin portal.",
"Title for applicant dashboard on the talent cloud admin portal.",
},
{
name: currentUser
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,11 @@ export const DashboardPage = ({ currentUser }: DashboardPageProps) => {
<AdminHero
title={intl.formatMessage(
{
defaultMessage: "Welcome back, {name}",
id: "lIwJp4",
defaultMessage:
"Welcome back<hidden> to your community dashboard</hidden>, {name}",
id: "2FrqUn",
description:
"Title for dashboard on the talent cloud admin portal.",
"Title for community dashboard on the talent cloud admin portal.",
},
{
name: currentUser
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,13 +247,14 @@ const DashboardHeading = ({ userQuery }: DashboardHeadingProps) => {
<Hero
title={intl.formatMessage(
{
defaultMessage: "Welcome back, {firstName}",
id: "Q/f5AF",
defaultMessage:
"Welcome back<hidden> to your applicant dashboard</hidden>, {name}",
id: "bw4CAS",
description:
"Title displayed in the hero section of the Search page.",
"Title for applicant dashboard on the talent cloud admin portal.",
},
{
firstName: user.firstName,
name: user.firstName,
},
)}
subtitle={intl.formatMessage(
Expand Down
Loading