Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Add context to dashboard page titles #12397

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

esizer
Copy link
Member

@esizer esizer commented Dec 31, 2024

πŸ€– Resolves #11978

πŸ‘‹ Introduction

Adds hidden text to the dashboard titles to improve context for non-visual users.

πŸ•΅οΈ Details

Hopefully we find a more permanent solution as this is a stop gap since:

  • We know we have issues with hidden text in voiceover
  • They still lack context for visual users

πŸ§ͺ Testing

  1. Build the app pnpm run dev:fresh
  2. Login as admin [email protected]
  3. Navigate to the applicant dashboard /applicant
  4. Confirm the h1 indicates the page you are on in hidden text
  5. Repeat step 4 on the admin dashboard /admin
  6. Login as the community admin [email protected]
  7. Repeat step 4 onm the community dashboard /community

@esizer esizer marked this pull request as ready for review December 31, 2024 18:26
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I get an extra space before the comma but I guess we know there are quirks with the hidden text approach.
image

@esizer esizer added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit f0e93b8 Jan 2, 2025
14 of 15 checks passed
@esizer esizer deleted the 11978-add-dashboard-heading-context branch January 2, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⌨ Dashboards all have same title
2 participants