Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: task: add script to generate a GHA matrix #25

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cngJo
Copy link
Contributor

@cngJo cngJo commented May 23, 2023

First version. Can currently only generate a GHA Matrix.

Open points:

  • how to exclude certain PHP versions for shopware versions? Can we just hard-code the Version steps?

Fixes #14

scripts/generate-matrix.js Outdated Show resolved Hide resolved
@shyim
Copy link
Member

shyim commented May 25, 2023

Only missing part seems now the GHA changes. JS looks good :)

@cngJo
Copy link
Contributor Author

cngJo commented May 25, 2023

Yes, but also the use of the new static-data from FriendsOfShopware/shopware-static-data#1 needs to be integrated.

I already have a version for that locally, I'm currently testing.

@cngJo
Copy link
Contributor Author

cngJo commented May 25, 2023

Also, FriendsOfShopware/shopware-static-data#2 needs to be merged for this, since the code in did not respect minified responses from the Packagist API which.

@cngJo cngJo force-pushed the feature/14-auto-generate-matrix branch 2 times, most recently from fdb024f to 4b3e953 Compare May 26, 2023 16:26
@cngJo cngJo force-pushed the feature/14-auto-generate-matrix branch from 4b3e953 to 82fc1df Compare May 26, 2023 16:27
@aragon999
Copy link
Member

First of all, thanks a lot. I will go through the changes the next days :-)

@aragon999 aragon999 self-assigned this May 30, 2023
@cngJo
Copy link
Contributor Author

cngJo commented May 30, 2023

Thanks! I've run into issue when the current matrix would exceed the max amount of Matrix Runners you can start, so I started working on an option that would allow you to build the matrix by major version.

This worked for 6.5, but not for 6.4 since, we there are still over the limit. We might need to adapt the logic to generate the matrix by major.minor.

But if we decide to split it up further, we need to find a proper solution for the hard coded versions like trunk. Maybe just throw it into a JSON file in the repo, and/or add an option to specify hard-coded as a version to the bin/generate-matrix.js script.

@tinect
Copy link
Member

tinect commented Sep 4, 2023

We could also stop generating for versions older than (f.e.) two years. This would mean, we would not generate anything for <6.4.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: auto-update shopware versions in build-docker-images.yaml
4 participants