Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate matrix, auto-remove outdated versions #30

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tinect
Copy link
Member

@tinect tinect commented Dec 8, 2023

Sorry, this small PR escalated quickly 🙈

Due to the support end of PHP 7.4 and 8.0, we should not waste energy on these things :-)

INFO: 8,3 fails, while there is no one published yet because it is introduced here, too.

@tinect tinect requested a review from aragon999 December 8, 2023 20:51
@tinect tinect changed the title stop php 7.4 and 8.0 generate matrix, auto-remove outdated versions Dec 10, 2023
@tinect tinect force-pushed the stop-php-7.4-and-8.0 branch 2 times, most recently from 592303d to bc16482 Compare December 23, 2023 23:49
@aragon999
Copy link
Member

Mh, I have been thinking, but I think I am not yet ready to drop support for the Shopware Images < 6.4.6 images, although the supported PHP versions are not provided with security Updates anymore.

This is due to the fact, that we sometimes still publish plugin updates for Shopware 6.4.x and therefore want to run the tests and probably also have an up to date shopware-cli and not make sure that we only use features depending on the Shopware version.

But I will have a more careful look at the PR (hopefully soon) :-) and clean it up/rebase it and merge it.

@tinect
Copy link
Member Author

tinect commented Feb 5, 2024

@aragon999 thank you. but you are able to build with a newer shopware version, aren‘t you? 🤔

@aragon999
Copy link
Member

Yes but I cannot run the tests :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants