Implementing matrix strategy to speed up gha-only tests #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankross
changed the title
sckott
reviewed
Dec 18, 2024
Adding inputs and options jsons to matrix approach
tefirman
reviewed
Dec 18, 2024
tefirman
reviewed
Dec 18, 2024
sckott
approved these changes
Dec 18, 2024
tefirman
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Great call on making the inputs.json and options.json optional. Looks great, thanks @seankross !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for splitting hairs but I feel like this is the better implementation practice compared to #22. Looking for approval from both @tefirman and @sckott before merging. Also sorry for the sloppy merging. If this gets approval I will close #22.