Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cromwell API tests to dos #33

Closed
10 of 11 tasks
sckott opened this issue Dec 18, 2024 · 3 comments · Fixed by #51
Closed
10 of 11 tasks

Cromwell API tests to dos #33

sckott opened this issue Dec 18, 2024 · 3 comments · Fixed by #51
Labels
infrastructure Infrastructure fix to execute WDL GitHub Actions

Comments

@sckott
Copy link
Collaborator

sckott commented Dec 18, 2024

sckott added a commit that referenced this issue Dec 18, 2024
@sckott sckott linked a pull request Jan 10, 2025 that will close this issue
@sckott
Copy link
Collaborator Author

sckott commented Jan 14, 2025

@seankross in above item starting with

add input options to these tests to turn off caching ...

I'm embarrassed to admit I don't remember what this was about. Do you? In the tests that run cromwell via java that you and taylor started we are using the options.json files if it exists that have caching config in them. We're not currently using those if they exist in these api tests yet, but can do.

@seankross
Copy link
Collaborator

We're not currently using those if they exist in these api tests yet, but can do.

I do want to use the options.json files in the api tests if they exist. Does that answer your question?

@tefirman tefirman added the infrastructure Infrastructure fix to execute WDL GitHub Actions label Jan 14, 2025
@sckott
Copy link
Collaborator Author

sckott commented Jan 14, 2025

I think that was it - to use any caching options in an input file. I'll add this functionality to the code

sckott added a commit that referenced this issue Jan 15, 2025
…n files when submitting cromwell jobs; tweak helper funs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure fix to execute WDL GitHub Actions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants