Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create simple dwa pkg #7

Merged
merged 14 commits into from
Jun 30, 2024
Merged

feat: create simple dwa pkg #7

merged 14 commits into from
Jun 30, 2024

Conversation

Autumn60
Copy link
Collaborator

@Autumn60 Autumn60 commented Jun 29, 2024

#5 #6 を含みます。

コスト計算部分を除くDWAPlannerパッケージの枠組みを作成・実装。

@Autumn60 Autumn60 linked an issue Jun 29, 2024 that may be closed by this pull request
Copy link
Contributor

@RyodoTanaka RyodoTanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメント部分の修正をお願いします!


Window window = generate_window(twist);

double min_cost = 1e6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::numeric_limits::max()を使うのが良いと思います!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対象の箇所を下記で修正しました。
e5982e6

@RyodoTanaka RyodoTanaka self-requested a review June 30, 2024 05:22
Copy link
Contributor

@RyodoTanaka RyodoTanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正されたのでヨシ!

@RyodoTanaka RyodoTanaka merged commit 6e22d04 into main Jun 30, 2024
@RyodoTanaka RyodoTanaka deleted the feat/simple_dwa branch June 30, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Planner
2 participants