Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an HTTPS Agent and HTTPS scheme if RED.settings.https is set #1488

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Nov 20, 2024

fixes #1473

Description

Supersedes #1480

  • Checks RED.settings.https is "something" and if yes:
    • switches the URL scheme to "https://"
    • Adds an HTTPS Agent & spreads whatever is in RED.settings.https into the Agent (permitting any extras to be included or to override the default rejectUnauthorized: false if so desired)

NOTE:

I have tested a variation of this code on a users VM (thanks for the support @Paul-Reed)
By variation, I mean an older branch but the relevant parts of this PR were used and verified.

Related Issue(s)

#1473

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from knolleary November 20, 2024 09:02
@Steve-Mcl Steve-Mcl linked an issue Nov 20, 2024 that may be closed by this pull request
nodes/config/ui_base.js Outdated Show resolved Hide resolved
@Steve-Mcl Steve-Mcl requested a review from knolleary November 20, 2024 10:08
@joepavitt
Copy link
Collaborator

Oddly keep getting 2 x slider tests failing, but I see no reason as to why that would be caused by this.

@Steve-Mcl
Copy link
Contributor Author

Oddly keep getting 2 x slider tests failing, but I see no reason as to why that would be caused by this.

This is (deliberately) based of the newer WYSIWYG work since it fixed something in this area and I didnt want to do the work twice.

In theory, the problem lies in the base branch (not this)

Investigating base branch widget-wysiwyg

@Steve-Mcl Steve-Mcl merged commit 281e3c2 into widget-wysiwyg Dec 13, 2024
1 of 2 checks passed
@Steve-Mcl Steve-Mcl deleted the 1480-https-editing branch December 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 error when layout editor attempts to save changes
3 participants