Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WYSIWYG: Widget resizing and re-ordering #1469

Merged
merged 14 commits into from
Dec 13, 2024
Merged

WYSIWYG: Widget resizing and re-ordering #1469

merged 14 commits into from
Dec 13, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Nov 14, 2024

closes #1468

Description

  • Adds widget reordering (within its own group)
  • Adds widget resizing
  • Adjusts CSS of sizing handles to make them less opaque/less obtrusive when not editing a widget
    • they are raised to opacity 1 upon hover/active
  • Re-worked the deploy to node-red promise chain to async await (was able to crash Node-RED)

screenshots

chrome_CnOvBpBlUv

Related Issue(s)

#1468

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from joepavitt November 14, 2024 16:33
Steve-Mcl and others added 3 commits November 14, 2024 16:38
closes WYSIWYG: Ability to add and remove spacers #1479
New Feature: wysiwyg design time editing - add and remove spacer widgets
@Steve-Mcl Steve-Mcl mentioned this pull request Nov 20, 2024
10 tasks
@joepavitt
Copy link
Collaborator

Playing around with this locally and it's just excellent. I've modified a little CSS here and there for the hover and make it clearer where the widgets start/finish, even when not hovered.

@joepavitt
Copy link
Collaborator

6 x Slider E2E failures, which is very odd and potentially overlaps with the issues we've seen in the Slider tests with #1488 too

@Steve-Mcl
Copy link
Contributor Author

6 x Slider E2E failures, which is very odd and potentially overlaps with the issues we've seen in the Slider tests with #1488 too

Yes, as #1488 is based off this branch (since it affects an area re-written in this PR and I didnt want to fix the HTTP issue twice)

The problem most likely lives in this branch.

Invistigating.

Steve-Mcl and others added 3 commits December 13, 2024 14:41
@Steve-Mcl
Copy link
Contributor Author

@joepavitt - tests passing now (except 1 random ui-control test)

  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  widgets/control.spec.js                  00:25       11        9        2        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤

    ✖  1 of 27 failed (4%)                      04:11      131      129        2        -        -  

@joepavitt
Copy link
Collaborator

Tests running fine locally, functionality also working well locally.

@joepavitt joepavitt merged commit 9d52ea9 into main Dec 13, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the widget-wysiwyg branch December 13, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WYSIWYG Widget sizing and re-ordering wihin a group
2 participants