Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform banners from the applications page #4939

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Dec 18, 2024

Description

#4885 (comment) nested application pages under team pages, and both injected platform banners.

Removed the application platform-banners and left only the team ones.

Related Issue(s)

introduced by #4885
closes #4938

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Dec 18, 2024
@cstns cstns requested a review from knolleary December 18, 2024 11:54
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (33ac8f7) to head (7e30c3e).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4939      +/-   ##
==========================================
- Coverage   78.64%   78.59%   -0.05%     
==========================================
  Files         324      325       +1     
  Lines       15265    15296      +31     
  Branches     3507     3512       +5     
==========================================
+ Hits        12005    12022      +17     
- Misses       3260     3274      +14     
Flag Coverage Δ
backend 78.59% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns merged commit 3a30552 into main Dec 18, 2024
17 of 18 checks passed
@cstns cstns deleted the remove-duplicate-admin-and-subscription-banners-from-the-applications-page branch December 18, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application view has double banners
2 participants