Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application view has double banners #4938

Closed
knolleary opened this issue Dec 18, 2024 · 1 comment · Fixed by #4939
Closed

Application view has double banners #4938

knolleary opened this issue Dec 18, 2024 · 1 comment · Fixed by #4939
Assignees
@cstns
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do
Milestone
2.12

Comments

@knolleary
Copy link
Member

Current Behavior

On an application view, we get double banners:

image

Expected Behavior

One banner

Steps To Reproduce

Have a team with a banner showing

Ways of triggering the banner:

  • Login as an admin and view a team you aren't a member of
  • View a team in trial mode
  • View a team with an expired subscription

Environment

  • FlowFuse version:
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser:

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate
@knolleary knolleary added bug Something isn't working needs-triage Needs looking at to decide what to do labels Dec 18, 2024
@knolleary knolleary added this to the 2.12 milestone Dec 18, 2024
@cstns cstns self-assigned this Dec 18, 2024
@cstns cstns mentioned this issue Dec 18, 2024
Merged
10 tasks
@cstns
Copy link
Contributor

cstns commented Dec 18, 2024

fixed by #4939

@cstns cstns closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cstns cstns

Labels
bug Something isn't working needs-triage Needs looking at to decide what to do
Projects
☁️ Product Planning
Status: Closed / Done
Milestone
2.12
Development

Successfully merging a pull request may close this issue.

Remove platform banners from the applications page FlowFuse/flowfuse
2 participants
@knolleary @cstns