Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent storage #163

Merged
merged 29 commits into from
Jul 2, 2024
Merged

Persistent storage #163

merged 29 commits into from
Jul 2, 2024

Conversation

hardillb
Copy link
Contributor

fixes FlowFuse/flowfuse#4003

Description

Adds support for mounting a PVC on /data/storage to allow for using the standard filesystem nodes.

Also refactors all K8s templates into their own file to make things a little cleaner.

Related Issue(s)

FlowFuse/flowfuse#4003

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Jun 17, 2024
@hardillb hardillb mentioned this pull request Jun 17, 2024
Merged
13 tasks
hardillb added 3 commits June 18, 2024 16:26
@hardillb
Use project.id rather than name for PVC
5da30bc 
This is to stop people reusing the a project name and getting
access to an existing directory before it is deleted
@hardillb
Add aws efs magic
cc42b7a
@hardillb
Add EFS to readme
2747f72
@hardillb hardillb changed the title Persisten storage Persistent storage Jun 20, 2024
@hardillb hardillb added this to the 2.6 milestone Jun 20, 2024
@hardillb hardillb requested a review from knolleary June 27, 2024 14:53
@hardillb hardillb marked this pull request as ready for review June 27, 2024 14:54
@hardillb hardillb marked this pull request as draft June 28, 2024 13:36
@hardillb hardillb marked this pull request as ready for review June 28, 2024 18:46
knolleary
knolleary requested changes Jul 1, 2024
View reviewed changes
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple console.logs still in lib/aws-efs.js to move over to proper log statements.

@hardillb
Copy link
Contributor Author

hardillb commented Jul 1, 2024

@knolleary I've removed the console.logs as they were mainly sanity checks as I was building it and we don't have the app object in scope to log them.

@hardillb hardillb requested a review from knolleary July 1, 2024 12:16
@hardillb hardillb merged commit 8ccd098 into main Jul 2, 2024
3 checks passed
@hardillb hardillb deleted the persisten-storage branch July 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

Update k8s driver to attach storage to instances
2 participants
@hardillb @knolleary