Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CWD to storage dir #250

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Set CWD to storage dir #250

merged 1 commit into from
Jul 4, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jun 17, 2024 •
edited
Loading

part of FlowFuse/flowfuse#3056

Description

Ensure that the Node-RED CWD is userDir/storage so files written without a path end up on the persistent volume.

DO NOT MERGE BEFORE ALL THE DRIVERS ARE UPDATED
I will add a check list for this.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Merge first

@hardillb hardillb self-assigned this Jun 17, 2024
@hardillb hardillb mentioned this pull request Jun 17, 2024
Merged
10 tasks
@hardillb hardillb mentioned this pull request Jul 1, 2024
Merged
10 tasks
@hardillb hardillb marked this pull request as ready for review July 2, 2024 10:24
@hardillb hardillb requested a review from knolleary July 3, 2024 10:34
@hardillb hardillb mentioned this pull request Jul 3, 2024
Closed
@knolleary
Copy link
Member

@hardillb Approved - will let you merge given the warnings above

@hardillb hardillb merged commit a5ba57e into main Jul 4, 2024
5 checks passed
@hardillb hardillb deleted the persistent-storage branch July 4, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @knolleary