Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] "auto_tuner" should be under the field config.experiment. #301

Merged
merged 3 commits into from
Jan 2, 2025
Merged

[Fix] "auto_tuner" should be under the field config.experiment. #301

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e788c51
Update runner_train.py Update runner_train.py, “no_shared_fs" should …
changsci Dec 30, 2024
bbf5b5f
Merge branch 'FlagOpen:main' into main
changsci Dec 31, 2024
a0cbbf4
[Fix] "auto_tuner" should be under the field config.experiment
changsci Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flagscale/auto_tuner/record/recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def __init__(self, config):
)
# Metric to grep in the last rank of last node log file
if (
"auto_tuner" in self.config
"auto_tuner" in self.config.experiment
and "performance" in self.config.experiment.auto_tuner
):
self.metric = self.config.experiment.auto_tuner.performance.get(
Expand All @@ -28,7 +28,7 @@ def __init__(self, config):

# Sort order of performance, order just in [ascend, and descend], default ascend
if (
"auto_tuner" in self.config
"auto_tuner" in self.config.experiment
and "performance" in self.config.experiment.auto_tuner
):
self.sorted_order = self.config.experiment.auto_tuner.performance.get(
Expand Down
Loading