[Fix] "auto_tuner" should be under the field config.experiment. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be under the field "runner"
change
no_shared_fs = config.experiment.get("no_shared_fs", False)
to
no_shared_fs = runner_config.get("no_shared_fs", False)
I want to change the default metric to TFLOPs and change the order to descend, but it doesn't work. Because, the "auto_tuner" is under config.experiment instead of config.
After making the following changes it worked.
Change
if (
"auto_tuner" in self.config
and "performance" in self.config.experiment.auto_tuner
):
to
if (
"auto_tuner" in self.config.experiment
and "performance" in self.config.experiment.auto_tuner
):
|
Thank you for your valuable input! Your contribution is greatly appreciated. |
heavyrain-lzy
pushed a commit
to heavyrain-lzy/FlagScale
that referenced
this pull request
Jan 3, 2025
fix test_parallel_context.py fix ut [Fix] "auto_tuner" should be under the field config.experiment. (FlagOpen#301) I want to change the default metric to TFLOPs and change the order to descend, but it doesn't work. Because, the "auto_tuner" is under config.experiment instead of config. After making the following changes it worked. Change if ( "auto_tuner" in self.config and "performance" in self.config.experiment.auto_tuner ): to if ( "auto_tuner" in self.config.experiment and "performance" in self.config.experiment.auto_tuner ): add 'attention_backend: unfused' for functional tests update extra validation feature (FlagOpen#303) 1. usage: ```yaml extra_eval_interval: 5 extra_valid_data_path: [ weight1, data_path1, weight2, data_path2, ] ``` - `weight` refers to the number of tokens for extra validation in `data_path`. - **NOTE: The extra validation always starts from consumed_sample=0.** 2. output format ``` (min, max) time across ranks (ms): evaluate .......................................: (xxx, xxx) ------------------------------------------------------------------------------- extra validation iteration 5 loss at data_path1 | consumed samples: xxx | lm loss value: xxx | lm loss PPL: xxx | ------------------------------------------------------------------------------- (min, max) time across ranks (ms): evaluate .......................................: (xxx, xxx) ------------------------------------------------------------------------------- extra validation iteration 5 loss at data_path2 | consumed samples: xxx | lm loss value: xxx | lm loss PPL: xxx | ------------------------------------------------------------------------------- ``` Fix extra validation corner case (FlagOpen#304) polish train.py
|
@changsci Thank you for the two provided fix PRs. Are you still a student? If so, FlagScale also offers some internship opportunities. If you are interested, you can contact us via email: [email protected] |
|
Thanks for your letter. Currently, I am working for ZTE. It must be mentioned that this project has inspired me greatly. It is truly a remarkable project. I sincerely hope it will continue to thrive and be seen by more developers.
Thank you again for sharing this wonderful project!
…---Original---
From: ***@***.***>
Date: Fri, Jan 3, 2025 17:40 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [FlagOpen/FlagScale] [Fix] "auto_tuner" should be under the fieldconfig.experiment. (PR #301)
@changsci Thank you for the two provided fix PRs. Are you still a student? If so, FlagScale also offers some internship opportunities. If you are interested, you can contact us via email: ***@***.***
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@changsci Thank you so much. I really appreciate it. Looking forward to more exchanges and let's keep in touch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to change the default metric to TFLOPs and change the order to descend, but it doesn't work. Because, the "auto_tuner" is under config.experiment instead of config.
After making the following changes it worked.
Change
if (
"auto_tuner" in self.config
and "performance" in self.config.experiment.auto_tuner
):
to
if (
"auto_tuner" in self.config.experiment
and "performance" in self.config.experiment.auto_tuner
):