Update PyDantic to V2 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not intended to be merged directly, using it to test the fixes for the merge conflicts. The branch failed tests locally for me |
|
This works locally. I am doing further testing using PyBaMM |
kratman
commented
Dec 16, 2024
|
@rtimms There are still a lot of changes that did not need to be in here, but this covers most of my findings |
|
Changes from @chuckliu1979's PR:
|
rtimms
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to pydantic v2, and builds on #51
This was intended to be part of my review of #51, by moving some of the code back to the original location
Fixes #38