feat: migrate to pydantic v2 #51
Conversation
|
rollback typing hint for python 3.8 compat, tested on python 3.8/3.9/3.10/3.11/3.12, all pass. |
|
Apologies for seeing this late, @chuckliu1979 – just triggered CI for you here, thanks! |
| from .parsers import parse_bpx_str, parse_bpx_obj, parse_bpx_file | ||
| from .utilities import get_electrode_stoichiometries, get_electrode_concentrations | ||
|
|
||
| def parse_bpx_obj(bpx: dict, v_tol: float = 0.001) -> BPX: |
There was a problem hiding this comment.
why have these been moved here from parsers?
There was a problem hiding this comment.
I agree, this should go back to parsers
|
@agriyakhetarpal do you think you could help with a review? The changes to pydantic look ok to me but there are some other changes to tests etc. it would be good to get a second pair of eyes on |
|
also note we dropped python 3.8 |
|
Yes, thanks for the ping – I'll try to review this week! |
| from .parsers import parse_bpx_str, parse_bpx_obj, parse_bpx_file | ||
| from .utilities import get_electrode_stoichiometries, get_electrode_concentrations | ||
|
|
||
| def parse_bpx_obj(bpx: dict, v_tol: float = 0.001) -> BPX: |
There was a problem hiding this comment.
I agree, this should go back to parsers
There was a problem hiding this comment.
Why was this removed during a PyDantic change? Can we split that into a different PR?
There was a problem hiding this comment.
Is this necessary? I don't see how this is related
| if TYPE_CHECKING: | ||
| from collections.abc import Callable | ||
|
|
||
| from pydantic import GetCoreSchemaHandler, GetJsonSchemaHandler |
There was a problem hiding this comment.
Can we just enable type checking all the time
| readme = "README.md" | ||
| dynamic = ["version", "description"] | ||
| requires-python = ">=3.8" |
There was a problem hiding this comment.
This probably should not be 3.8 anymore
There was a problem hiding this comment.
Did we need to rewrite this whole file?
bpx still use pydantic v1, our project need pydantic v2, hence i migrate this project to pydantic v2