Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make out of media a mishap and kill SideEffect earlyExit #776

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Make out of media a mishap and kill SideEffect earlyExit #776

merged 3 commits into from
Nov 12, 2024

Conversation

vgskye
Copy link
Contributor

@vgskye vgskye commented Nov 2, 2024 •
edited
Loading

supersedes #769.
Visible behaviour changes from this PR:

  • Out of media correctly stops circle execution(closes Circles behave strangely on out of media #758)
  • Out of media now turns the pattern red and chat messages are now tagged with the pattern's name
  • Death from overcasting also shows the out of media message
  • Overcasting is more forgiving; Spells that would kill you and still fail no longer kill you
  • Other media overspending also no longer spends all your media

SamsTheNerd
SamsTheNerd requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@SamsTheNerd SamsTheNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks fine to me

Common/src/main/java/at/petrak/hexcasting/api/casting/eval/CastingEnvironment.java Show resolved Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/castables/ConstMediaAction.kt Show resolved Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/eval/sideeffects/OperatorSideEffect.kt Show resolved Hide resolved
Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapNotEnoughMedia.kt Show resolved Hide resolved
@vgskye vgskye requested a review from SamsTheNerd November 6, 2024 07:39
SamsTheNerd
SamsTheNerd reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@SamsTheNerd SamsTheNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine to me. PR should probably be tested in game (unclear if it was already or not). I'm not doing that rn, but poke me once that's done if I haven't gotten to it myself.

@SamsTheNerd SamsTheNerd merged commit dbc1cb4 into FallingColors:main Nov 12, 2024
4 checks passed
@vgskye vgskye mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamsTheNerd SamsTheNerd SamsTheNerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Hex Casting
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circles behave strangely on out of media
2 participants
@vgskye @SamsTheNerd