Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scout's with no media and no enlightenment still succeeds #408

Closed
object-Object opened this issue Feb 5, 2023 · 7 comments
Closed

Scout's with no media and no enlightenment still succeeds #408

object-Object opened this issue Feb 5, 2023 · 7 comments
Labels
1.19 1.20 bug Something isn't working

Comments

@object-Object
Copy link
Member

2023-02-04_21 36 38

@SamsTheNerd
Copy link
Member

i think this is an issue with all ConstMediaActions. Not sure if it's changed for 0.11 though

@object-Object
Copy link
Member Author

Let's test it in the 1.20.1 prereleases.

@Ch1216
Copy link

Ch1216 commented Apr 20, 2024

Issue still present in Fabric 0.15.10 Hex casting pre-634

@object-Object
Copy link
Member Author

object-Object commented May 5, 2024

The issue occurs because ConstMediaAction calls execute in Action#operate, which runs before media is withdrawn in side effects.

image

I guess the fix would be to do something similar to SpellAction, where ConstMediaAction adds a side effect to actually do the work of the action?

(edit: seems to work the same on 1.19 and 1.20)

@object-Object
Copy link
Member Author

okay, I see why it doesn't already work like that - none of the side effects on 1.19 are able to modify the harness state, so they wouldn't be able to push stuff to the stack. In 1.20 we could maybe use AttemptSpell?

@vgskye
Copy link
Contributor

vgskye commented Nov 26, 2024

this should have been fixed by #776?

@Ch1216
Copy link

Ch1216 commented Nov 26, 2024

Can confirm that this Issue was fixed by the Hexcasting 0.11.2 release

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Hex Casting Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.19 1.20 bug Something isn't working
Projects
Status: ✅ Done
Status: 📋 Backlog
Development

No branches or pull requests

4 participants