New Shooting patch #249
Merged
New Shooting patch #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not tested yet |
|
Noooooo not the build errors forcing me to re-enable analyzers😭 |
VALERA771
requested changes
Dec 1, 2024
|
Also in future use pr template |
|
I made it even worse by trying to rebase it on current scpsl14... |
Banalny-Banan
force-pushed
the
scpsl14
branch
from
36c0b7c to
407ee99
Compare
…an/scpsl14 # Conflicts: # EXILED/Exiled.Events/Patches/Events/Player/Shooting.cs
|
Still needs testing btw |
VALERA771
added
the
Requires Testing
|
@VALERA771 I tested and fixed everything, should be ready to merge |
|
Some docs like claim's target position remark should be added as remarks |
IRacle1
requested changes
Dec 1, 2024
|
Other things and patch itself ill check again tmrw😊 |
IRacle1
approved these changes
Dec 3, 2024
VALERA771
removed
the
Requires Testing
VALERA771
approved these changes
Dec 4, 2024
VALERA771
reviewed
Dec 4, 2024
VALERA771
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.