Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test suites quiet(er) #99

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Make test suites quiet(er) #99

merged 2 commits into from
Dec 4, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Nov 28, 2024

PR Goal?

Reduce the amount of output generated by our test suites.

Feedback sought?

general validation

Priority?

medium

Tests added?

it's just tests! :)

How to test?

run everyvoice/run_tests.py fs2 with and without -q and enjoy the reduced output.

Confidence?

high

Version change?

no

Related PRs?

EveryVoiceTTS/EveryVoice#599

Other comments

This PR rolls in #98 so I can get coverage reports for this PR.

It also illustrates how the strategy of checking out EV's branch of the same name is working as desired.

Copy link

semanticdiff-com bot commented Nov 28, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  fs2/tests/test_writing_callbacks.py  91% smaller
  fs2/tests/test_loading.py  90% smaller
  .coveragerc Unsupported file format
  .github/workflows/test.yml Unsupported file format
  fs2/tests/test_cli.py  0% smaller

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@7b50b38). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage        ?   44.98%           
=======================================
  Files           ?       22           
  Lines           ?     1445           
  Branches        ?        0           
=======================================
  Hits            ?      650           
  Misses          ?      795           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanise joanise requested a review from marctessier November 28, 2024 19:15
@joanise joanise merged commit 2fd8eb4 into main Dec 4, 2024
6 checks passed
@joanise joanise deleted the dev.ej/quiet-test-suites branch December 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant