Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test suites quiet(er) #599

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Make test suites quiet(er) #599

merged 6 commits into from
Dec 4, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Nov 27, 2024

PR Goal?

Reduce the amount of output generated by our test suites.

Also fixed an issue where some of our doctest tests were not actually picked up.

Feedback sought?

general validation

Priority?

medium

Tests added?

it's all about testing

How to test?

Try everyvoice/run_tests.py with and without -q and enjoy how much less output there is on screen now.

Confidence?

high

Version change?

no

Related PRs?

none at the moment (there may be one for fs2 eventually, it's still pretty verbose)

EveryVoiceTTS/FastSpeech2_lightning#99

Copy link

semanticdiff-com bot commented Nov 27, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/tests/test_model.py  94% smaller
  everyvoice/tests/test_dataloader.py  86% smaller
  everyvoice/tests/test_cli.py  86% smaller
  everyvoice/tests/test_configs.py  76% smaller
  everyvoice/tests/test_preprocessing.py  67% smaller
  everyvoice/tests/preprocessed_audio_fixture.py  67% smaller
  everyvoice/tests/test_text.py  63% smaller
  everyvoice/tests/test_utils.py  52% smaller
  everyvoice/cli.py  17% smaller
  everyvoice/run_tests.py  13% smaller
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller
  everyvoice/tests/stubs.py  0% smaller
  everyvoice/tests/test_doctests.py  0% smaller
  everyvoice/tests/test_wizard.py  0% smaller

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.74%. Comparing base (5b66fea) to head (22c67a6).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
everyvoice/cli.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   76.59%   76.74%   +0.15%     
==========================================
  Files          46       46              
  Lines        3452     3445       -7     
  Branches      470      470              
==========================================
  Hits         2644     2644              
+ Misses        706      700       -6     
+ Partials      102      101       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanise joanise force-pushed the dev.ej/quiet-test-suites branch from c980c4f to 9b89c74 Compare November 27, 2024 22:50
Copy link
Contributor

github-actions bot commented Nov 27, 2024

CLI load time: 0:00.36
Pull Request HEAD: 22c67a61a4662f0cff61321dfe6a10345932c9e2
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1134 |     108962 |     typer.main
import time:       308 |     128463 |   typer
import time:       280 |     106270 |       everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.cli
import time:       184 |     106902 |     everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli
import time:        19 |     106920 |   everyvoice.model.feature_prediction.FastSpeech2_lightning.fs2.cli.preprocess
import time:      7691 |     270651 | everyvoice.cli

@joanise
Copy link
Member Author

joanise commented Dec 2, 2024

MT noticed the all suite is not defined, but is mentioned in the docs. Will add it before merging.

@joanise joanise force-pushed the dev.ej/quiet-test-suites branch 2 times, most recently from 3d70a37 to 6818ca1 Compare December 4, 2024 14:44
Copy link
Collaborator

@marctessier marctessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the output and and how we don't see any good "ERROR" .

It produces a nice and clean output :-)

Ran 210 tests in 178.494s

OK

@joanise joanise force-pushed the dev.ej/quiet-test-suites branch from 6818ca1 to 22c67a6 Compare December 4, 2024 16:00
@joanise joanise merged commit 7a8fb71 into main Dec 4, 2024
6 checks passed
@joanise joanise deleted the dev.ej/quiet-test-suites branch December 4, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants