-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test suites quiet(er) #599
Conversation
Changed Files
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
+ Coverage 76.59% 76.74% +0.15%
==========================================
Files 46 46
Lines 3452 3445 -7
Branches 470 470
==========================================
Hits 2644 2644
+ Misses 706 700 -6
+ Partials 102 101 -1 ☔ View full report in Codecov by Sentry. |
c980c4f
to
9b89c74
Compare
|
MT noticed the |
3d70a37
to
6818ca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the output and and how we don't see any good "ERROR" .
It produces a nice and clean output :-)
Ran 210 tests in 178.494s
OK
Unit test should be quiet.
also include doctests for one module we had forgotten to activate
6818ca1
to
22c67a6
Compare
PR Goal?
Reduce the amount of output generated by our test suites.
Also fixed an issue where some of our doctest tests were not actually picked up.
Feedback sought?
general validation
Priority?
medium
Tests added?
it's all about testing
How to test?
Try
everyvoice/run_tests.py
with and without-q
and enjoy how much less output there is on screen now.Confidence?
high
Version change?
no
Related PRs?
none at the moment (there may be one for fs2 eventually, it's still pretty verbose)EveryVoiceTTS/FastSpeech2_lightning#99