Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce xpay INFO verbosity #7933

Merged
merged 1 commit into from
Dec 15, 2024
Merged

reduce xpay INFO verbosity #7933

merged 1 commit into from
Dec 15, 2024

Conversation

1ma
Copy link
Contributor

@1ma 1ma commented Dec 11, 2024

My lightningd logs are getting hammered by a particular log from v24.11's xpay plugin:

2024-12-11T16:29:03.439Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:29:03.440Z INFO    plugin-cln-xpay: Got command datastore
2024-12-11T16:30:02.530Z INFO    plugin-cln-xpay: Got command listpeerchannels
2024-12-11T16:30:03.440Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:30:03.441Z INFO    plugin-cln-xpay: Got command datastore
2024-12-11T16:31:03.493Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:31:03.493Z INFO    plugin-cln-xpay: Got command datastore
2024-12-11T16:32:03.495Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:32:03.496Z INFO    plugin-cln-xpay: Got command datastore
2024-12-11T16:33:03.555Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:33:03.555Z INFO    plugin-cln-xpay: Got command datastore
2024-12-11T16:34:03.589Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:34:03.589Z INFO    plugin-cln-xpay: Got command datastore
2024-12-11T16:35:02.592Z INFO    plugin-cln-xpay: Got command listpeerchannels
2024-12-11T16:35:03.590Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:35:03.590Z INFO    plugin-cln-xpay: Got command datastore
2024-12-11T16:36:03.649Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:36:03.650Z INFO    plugin-cln-xpay: Got command datastore
2024-12-11T16:37:03.696Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:37:03.699Z INFO    plugin-cln-xpay: Got command datastore
2024-12-11T16:38:03.751Z INFO    plugin-cln-xpay: Got command askrene-age
2024-12-11T16:38:03.752Z INFO    plugin-cln-xpay: Got command datastore
...

IMO it would make more sense to have this as a debug level log.

@Lagrang3
Copy link
Collaborator

This is fine to do. But the CI test would fail unless you add a Changelog line to the commit message.

@tobomobo tobomobo mentioned this pull request Dec 12, 2024
Closed
@rustyrussell
Copy link
Contributor

Yes, please add:

Changelog-Fixed: xpay no longer logs "Got command" at info level.

@rustyrussell rustyrussell added this to the v24.11.1 milestone Dec 15, 2024
@rustyrussell rustyrussell merged commit d6bd611 into ElementsProject:master Dec 15, 2024
39 checks passed
@1ma 1ma deleted the got-cmd-debug branch December 15, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lagrang3 Lagrang3 Lagrang3 approved these changes

@rustyrussell rustyrussell rustyrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v24.11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@1ma @Lagrang3 @rustyrussell