-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin-cln-xpay: Not redirecting pay (unknown arg \"maxfeepercent\") and overly verbose log entries #7926
Comments
The additional Log entries are already being examined. Reference: #7933 |
BTW. This is not a bug. If some arguments are not yet supported, we just let |
Connected to Zeus, I can pay after adding the patch #7936. UPD. I've also added the "status" field in the response. Now I've noticed that the list of |
maxfeepercent is use by Zeus, so let's make that work. maxfee is more precise, so it's the only xpay option (maxfee was added to pay later). Fixes: ElementsProject#7926 Signed-off-by: Rusty Russell <[email protected]>
maxfeepercent is use by Zeus, so let's make that work. maxfee is more precise, so it's the only xpay option (maxfee was added to pay later). Fixes: ElementsProject#7926 Changelog-Changed: JSON-RPC: With `xpay-handle-pay` set, xpay will now be used even if `pay` uses maxfeeprecent or exemptfee parameters (e.g. Zeus) Signed-off-by: Rusty Russell <[email protected]>
maxfeepercent is use by Zeus, so let's make that work. maxfee is more precise, so it's the only xpay option (maxfee was added to pay later). [ Fix to ppm logic by Lagrang3, thanks! --RR ] Fixes: ElementsProject#7926 Changelog-Changed: JSON-RPC: With `xpay-handle-pay` set, xpay will now be used even if `pay` uses maxfeeprecent or exemptfee parameters (e.g. Zeus) Signed-off-by: Rusty Russell <[email protected]>
maxfeepercent is use by Zeus, so let's make that work. maxfee is more precise, so it's the only xpay option (maxfee was added to pay later). [ Fix to ppm logic by Lagrang3, thanks! --RR ] Fixes: ElementsProject#7926 Changelog-Changed: JSON-RPC: With `xpay-handle-pay` set, xpay will now be used even if `pay` uses maxfeeprecent or exemptfee parameters (e.g. Zeus) Signed-off-by: Rusty Russell <[email protected]>
Issue and Steps to Reproduce
running v24.11 on Raspiblitz (x86 Proxmox VM)
When enabling
xpay
and trying to pay an invoice with Zeus, the redirect does not work becausemaxfeepercent
is an unknown argument forxpay
. Paying the same bolt11 invoice withlightning-cli xpay -k invstring=lnbc...
works immediately.Also when
xpay-handle-pay
is true I get the following 'spam' in my logsgetinfo
output{
"id": "XXX",
"alias": "XXX",
"color": "XXX",
"num_peers": 10,
"num_pending_channels": 0,
"num_active_channels": X,
"num_inactive_channels": 0,
"address": [
{
"type": "torv3",
"address": "XXX.onion",
"port": 9736
}
],
"binding": [
{
"type": "ipv4",
"address": "127.0.0.1",
"port": 9736
}
],
"version": "v24.11",
"blockheight": 874093,
"network": "bitcoin",
"fees_collected_msat": X,
"lightning-dir": "/home/bitcoin/.lightning/bitcoin",
"our_features": {
"init": "08a0880a8a59a1",
"node": "88a0880a8a59a1",
"channel": "",
"invoice": "02000002024100"
}
}
The text was updated successfully, but these errors were encountered: