Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-cln-xpay: Not redirecting pay (unknown arg \"maxfeepercent\") and overly verbose log entries #7926

Closed
tobomobo opened this issue Dec 10, 2024 · 3 comments · Fixed by #7942
Assignees

Comments

@tobomobo
Copy link

tobomobo commented Dec 10, 2024

Issue and Steps to Reproduce

running v24.11 on Raspiblitz (x86 Proxmox VM)

When enabling xpay and trying to pay an invoice with Zeus, the redirect does not work because maxfeepercent is an unknown argument for xpay. Paying the same bolt11 invoice with lightning-cli xpay -k invstring=lnbc... works immediately.

Also when xpay-handle-pay is true I get the following 'spam' in my logs

SCR-20241210-kyuc

getinfo output

{
"id": "XXX",
"alias": "XXX",
"color": "XXX",
"num_peers": 10,
"num_pending_channels": 0,
"num_active_channels": X,
"num_inactive_channels": 0,
"address": [
{
"type": "torv3",
"address": "XXX.onion",
"port": 9736
}
],
"binding": [
{
"type": "ipv4",
"address": "127.0.0.1",
"port": 9736
}
],
"version": "v24.11",
"blockheight": 874093,
"network": "bitcoin",
"fees_collected_msat": X,
"lightning-dir": "/home/bitcoin/.lightning/bitcoin",
"our_features": {
"init": "08a0880a8a59a1",
"node": "88a0880a8a59a1",
"channel": "",
"invoice": "02000002024100"
}
}

@tobomobo
Copy link
Author

The additional Log entries are already being examined.

Reference: #7933

@tobomobo tobomobo changed the title plugin-cln-xpay: Not redirecting pay (unknown arg \"maxfeepercent\") and confusing log entries plugin-cln-xpay: Not redirecting pay (unknown arg \"maxfeepercent\") and overly verbose log entries Dec 12, 2024
@Lagrang3
Copy link
Collaborator

Lagrang3 commented Dec 12, 2024

xpay doesn't have the maxfeepercent option. To fix this, the hook that translates the call to pay into xpay must
replace the maxfeepercent into a maxfee value.
I can do this. I've just recently did this with renepay.

BTW. This is not a bug. If some arguments are not yet supported, we just let pay do the payment
instead of xpay.

@Lagrang3
Copy link
Collaborator

Lagrang3 commented Dec 13, 2024

Connected to Zeus, I can pay after adding the patch #7936.
Still there is some UI detail to fix.
The payment goes through but Zeus screen shows an error screen with no message.
I think this is related to the fact that xpay does not reply with a status: complete field.

UPD. I've also added the "status" field in the response. Now I've noticed that the list of
payments shows 0 in the amount corresponding to the payments done with xpay as
reported in #7934

rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 16, 2024
maxfeepercent is use by Zeus, so let's make that work.

maxfee is more precise, so it's the only xpay option (maxfee was added
to pay later).

Fixes: ElementsProject#7926
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 16, 2024
maxfeepercent is use by Zeus, so let's make that work.

maxfee is more precise, so it's the only xpay option (maxfee was added
to pay later).

Fixes: ElementsProject#7926
Changelog-Changed: JSON-RPC: With `xpay-handle-pay` set, xpay will now be used even if `pay` uses maxfeeprecent or exemptfee parameters (e.g. Zeus)
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 16, 2024
maxfeepercent is use by Zeus, so let's make that work.

maxfee is more precise, so it's the only xpay option (maxfee was added
to pay later).

[ Fix to ppm logic by Lagrang3, thanks! --RR ]

Fixes: ElementsProject#7926
Changelog-Changed: JSON-RPC: With `xpay-handle-pay` set, xpay will now be used even if `pay` uses maxfeeprecent or exemptfee parameters (e.g. Zeus)
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 17, 2024
maxfeepercent is use by Zeus, so let's make that work.

maxfee is more precise, so it's the only xpay option (maxfee was added
to pay later).

[ Fix to ppm logic by Lagrang3, thanks! --RR ]

Fixes: ElementsProject#7926
Changelog-Changed: JSON-RPC: With `xpay-handle-pay` set, xpay will now be used even if `pay` uses maxfeeprecent or exemptfee parameters (e.g. Zeus)
Signed-off-by: Rusty Russell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants