Tiny cleanups #7236
Merged
Tiny cleanups #7236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Some refused, but I love this cleanup
===End Flaky Test Report===
=========================== short test summary info ============================
ERROR tests/test_closing.py::test_channel_lease_lessor_cheat - ValueError:
Node errors:
- lightningd-2: had BROKEN messages
Global errors:
ERROR tests/test_closing.py::test_channel_lease_lessee_cheat - ValueError:
Node errors:
- lightningd-1: had BROKEN messages
Global errors:
ERROR tests/test_opening.py::test_rbf_reconnect_tx_construct - ValueError:
Node errors:
- lightningd-2: had BROKEN messages
Global errors:
===== 111 passed, 613 skipped, 33 warnings, 3 errors in 434.56s (0:07:14) ======
Yep, you can see I didn't test DF. Fixed those, let's try again... |
rustyrussell
force-pushed
the
tiny-cleanups
branch
from
eb54a2d to
53de625
Compare
Rather than `allow_broken_log`, we have `broken_log` which is a regex indicating what log lines are expected. This tightens our tests significantly, as it will catch *unexpected* brokenness. Signed-off-by: Rusty Russell <[email protected]>
No need to explicitly free this var, we can use tmpctx. Signed-off-by: Rusty Russell <[email protected]>
It tells us if it's failed, so we should use that rather than reporting failure twice. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
tiny-cleanups
branch
from
53de625 to
316e05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several things which were gathering in unloved branches :)