lightningd: use return value of peer_start_channeld()

It tells us if it's failed, so we should use that rather than reporting failure twice. Signed-off-by: Rusty Russell <[email protected]>
ElementsProject · Apr 20, 2024 · cd7175b · cd7175b
1 parent 86c29b6
commit cd7175b
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/lightningd/opening_control.c b/lightningd/opening_control.c
@@ -453,8 +453,11 @@ static void opening_funder_finished(struct subd *openingd, const u8 *resp,
 	if (pbase)
 		wallet_penalty_base_add(ld->wallet, channel->dbid, pbase);
 
+	/* If this fails, it cleans up */
+	if (!peer_start_channeld(channel, peer_fd, NULL, false, NULL))
+		return;
+
 	funding_success(channel);
-	peer_start_channeld(channel, peer_fd, NULL, false, NULL);
 
 cleanup:
 	/* Frees fc too */
@@ -557,10 +560,9 @@ static void opening_fundee_finished(struct subd *openingd,
 	if (pbase)
 		wallet_penalty_base_add(ld->wallet, channel->dbid, pbase);
 
-	/* On to normal operation! */
-	peer_start_channeld(channel, peer_fd, fwd_msg, false, NULL);
-
-	tal_free(uc);
+	/* On to normal operation (frees if it fails!) */
+	if (peer_start_channeld(channel, peer_fd, fwd_msg, false, NULL))
+		tal_free(uc);
 	return;
 
 failed: