Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: lower the EC_SIGNATURE_DER_MAX_LOW_R_LEN constant to 70 #434

Merged
merged 1 commit into from
Nov 17, 2023
Merged

crypto: lower the EC_SIGNATURE_DER_MAX_LOW_R_LEN constant to 70 #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/wally_crypto.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,10 +359,10 @@ WALLY_CORE_API int wally_pbkdf2_hmac_sha512(
#define EC_SIGNATURE_LEN 64
/** The length of a compact recoverable signature produced by EC signing */
#define EC_SIGNATURE_RECOVERABLE_LEN 65
/** The maximum encoded length of a DER encoded signature */
/** The maximum encoded length of a DER signature (High-R, High-S), excluding sighash byte */
#define EC_SIGNATURE_DER_MAX_LEN 72
/** The maximum encoded length of a DER encoded signature created with `EC_FLAG_GRIND_R` */
#define EC_SIGNATURE_DER_MAX_LOW_R_LEN 71
/** The maximum encoded length of a DER signature created with `EC_FLAG_GRIND_R` (Low-R, Low-S), excluding sighash byte */
#define EC_SIGNATURE_DER_MAX_LOW_R_LEN 70
/** The length of a secp256k1 scalar value */
#define EC_SCALAR_LEN 32

Expand Down
6 changes: 3 additions & 3 deletions src/transaction.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ static void assert_tx_assumptions(void)
{
BUILD_ASSERT(WALLY_TXHASH_LEN == SHA256_LEN);
BUILD_ASSERT(sizeof(DUMMY_SIG) == EC_SIGNATURE_DER_MAX_LEN + 1);
BUILD_ASSERT(sizeof(DUMMY_SIG) - 1 == EC_SIGNATURE_DER_MAX_LOW_R_LEN + 1);
BUILD_ASSERT(sizeof(DUMMY_SIG) > EC_SIGNATURE_DER_MAX_LOW_R_LEN + 1);
}
/* LCOV_EXCL_STOP */

Expand Down Expand Up @@ -348,10 +348,10 @@ int wally_tx_witness_stack_set_dummy(struct wally_tx_witness_stack *stack,

if (flags == WALLY_TX_DUMMY_SIG) {
p = DUMMY_SIG;
len = sizeof(DUMMY_SIG);
len = sizeof(DUMMY_SIG); /* High-R, High-S plus sighash byte */
} else if (flags == WALLY_TX_DUMMY_SIG_LOW_R) {
p = DUMMY_SIG;
len = sizeof(DUMMY_SIG) - 1; /* Low-R signatures are always at least 1 byte shorter */
len = EC_SIGNATURE_DER_MAX_LOW_R_LEN + 1; /* Low-R, Low-S plus sighash byte */
} else if (flags != WALLY_TX_DUMMY_NULL)
return WALLY_EINVAL;
return wally_tx_witness_stack_set(stack, index, p, len);
Expand Down
2 changes: 1 addition & 1 deletion src/wasm_package/src/const.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const EC_PUBLIC_KEY_LEN = 33;
export const EC_PUBLIC_KEY_UNCOMPRESSED_LEN = 65;
export const EC_SCALAR_LEN = 32;
export const EC_SIGNATURE_DER_MAX_LEN = 72;
export const EC_SIGNATURE_DER_MAX_LOW_R_LEN = 71;
export const EC_SIGNATURE_DER_MAX_LOW_R_LEN = 70;
export const EC_SIGNATURE_LEN = 64;
export const EC_SIGNATURE_RECOVERABLE_LEN = 65;
export const EC_XONLY_PUBLIC_KEY_LEN = 32;
Expand Down
Loading