crypto: lower the EC_SIGNATURE_DER_MAX_LOW_R_LEN constant to 70 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constant is the size of signatures produced by wally when grinding. As wally (and libsecp256k1[-zkp]) always produce low-S signatures, the maximum size is 70 bytes plus the sighash byte for low-R signatures. This affects the dummy witness stack function, making transaction fee estimation more accurate.
|
utACK 168b676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constant is the size of signatures (excluding the sighash byte) produced by wally when grinding. As wally (and libsecp256k1[-zkp]) always produce low-S signatures, the maximum size is 70 bytes plus the sighash byte for low-R signatures.
This affects the dummy witness stack function, making transaction fee estimation more accurate.