Bump version to v1.0.0 #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgriffiths
force-pushed
the
build_updates
branch
from
44579eb to
f9ad057
Compare
Depending on the environment variable WALLY_ABI_PY_WHEEL_USE_LIB: * If "no" or unset (or any unsupported value, with a warning), then the status quo is maintained: the libwally-core code will be (re)built as "amalgamated" objects that will then be linked into the Python extension. * If "static", then libwallycore.a and libsecp256k1.a will be built using the Autotools-based build system and will then be statically linked into the Python native extension library. * If "shared", then libwallycore.so (libwallycore.dylib on macOS) will be built using the Autotools-based build system and will then be dynamically linked into the Python native extension library. In this case, the Python extension will not contain any libwally-core or libsecp256k1 code, and the dynamic linker will need to find and load the libwallycore shared library (and, transitively, the libsecp256k1 shared library) whenever the Python extension is loaded.
If the environment contains WALLY_ABI_PY_WHEEL_USE_PKG_SECP256K1=1 (and the amalgamated objects are not being built), then the pkgconfig Python module will be called to find the include path for the system-installed libsecp256k1_zkp, and the secp256k1 submodule will not be checked out. WALLY_ABI_PY_WHEEL_USE_PKG_SECP256K1 can alternatively be set to a specific package name if the pkg-config name of the system-installed libsecp256k1-zkp is something other than 'libsecp256k1_zkp'.
jgriffiths
force-pushed
the
build_updates
branch
from
f9ad057 to
6a9f407
Compare
jgriffiths
force-pushed
the
build_updates
branch
2 times, most recently
from
1e6a4b0 to
a60935b
Compare
multi-path is the descriptor extension; multi-index is the index within a multi-path that is used for derivation/script generation.
This marks the start of DSO versioning for libwallycore.so.
jgriffiths
force-pushed
the
build_updates
branch
from
a60935b to
6f67467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully the final set of changes to release v1.0.0