-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python linkage enhancements #433
Conversation
Oh, I see this is failing. It still works for Gentoo since my ebuild deletes the whole |
This is probably broken since the latest changes only generate a couple of files and then build with the amalgamation, instead of compiling everything twice. In terms of a mutually acceptable change, I expect the existing build to remain unchanged (i.e. use the amalgamation) for both win and non-win. You should control the optional building with shared linkage/prebuilt libs entirely with your env var. |
44579eb
to
f9ad057
Compare
91b7f9d
to
8139509
Compare
As of 40c5e5a, I no longer need to hack |
8139509
to
40c5e5a
Compare
40c5e5a
to
0f9acd6
Compare
I'm pulling this into the |
f9ad057
to
6a9f407
Compare
@whitslack can you confirm that #432 works for you? |
6a9f407
to
1e6a4b0
Compare
0f9acd6
to
1e6a4b0
Compare
@jgriffiths: 1e6a4b0 ticks every box on my wish list (except for one, which I hadn't previously mentioned):
The one gripe I still have, which I am okay to address in a later release, is that the libwally-core library differs depending on whether the Python module is configured to be built. Really, |
@whitslack thanks for testing, and your summary of matters from the gentoo POV. I am hoping to release 1.0.0 imminently so your final point will not make this release. I am open to addressing it in a future release though, even if in an optional manner as per the I appreciate your patience and responsiveness in getting these changes merged. |
(continued from #419)
On systems supporting Libtool (i.e., anything but Windows), skip compiling the "amalgamated" sources for the Python module and simply link in the just-built
libwallycore.a
andlibsecp256k1.a
.setup.py
: support optionally building and linking to libwally-core as a dynamic shared object ifWALLY_ABI_PY_WHEEL_USE_DSO=1
is set. Ignored on Windows, wheresetup.py
does not build libwally-core.