-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates related to Omega IOStreams #231
base: main
Are you sure you want to change the base?
Conversation
This requires E3SM-Project/Omega#132 |
93d18f0
to
a876c23
Compare
6dc2fda
to
60ddce2
Compare
60ddce2
to
28e5f4a
Compare
TestingWith these changes, I am able to run the manufactured solution test case with Omega on Chrysalis through all but the Results can be found here:
|
@cbegeman, I would appreciate your review when you get back from the holiday. You can look as much or as little as you have time for at the changes in If you want to run the |
This is needed because Omega uses `IOStreams`, whereas MPAS components use `streams`.
caa340e
to
b8a996d
Compare
This now needs E3SM-Project/Omega#176 |
b8a996d
to
f11d40e
Compare
One more submodule update?Ideally, we would wait for E3SM-Project/Omega#170 to be merged and update the Omega submodule one more time before merging this. TestingWith that branch (merged with Omega's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. I ran manufactured_solution/convergence_space tests successfully with both Omega/develop and MPAS-Ocean on chrys with intel. Thanks for all your work on this, @xylar!
This merge adds the capability to only copy streams from the Omega
Default.yml
file if they are explicitly requested by a given test case.Here, we also update the map of variables between MPAS-Ocean and Omega, and add placeholders for mapping dimension names once the new Omega names are fully supported. (See E3SM-Project/Omega#172).
This merge updates the manufactured solution test case to support Omega in all steps but
analysis
(which requires further development of the time variable, see E3SM-Project/Omega#169).Checklist
Testing
comment in the PR documents testing used to verify the changes