Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes reading dimensions for Omega decomposition and unused dimensions #176

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

philipwjones
Copy link

@philipwjones philipwjones commented Dec 3, 2024

The original Decomp read only legacy MPAS mesh files with older dimension/variable names. This adds support for the newer names in Omega conventions. Additional changes modify the behavior when missing variables or dimensions are encountered. Defined dimensions that are missing or unused in input files are ignored during the file read. Also, error or warning messages for missing dimensions or variables at the base IO level are now suppressed and the error is passed to the calling routine to determine the proper behavior. This eliminates warnings for harmless situations that can cause confusion and unnecessary output in the log file.

All unit tests pass on Chrysalis/Intel.

Checklist

  • Testing
    • A comment in the PR documents testing used to verify the changes including any tests that are added/modified/impacted.
    • CTest unit tests for new features have been added per the approved design.
    • Polaris tests for new features have been added per the approved design (and included in a test suite)
    • Unit tests have passed. Please provide a relevant CDash build entry for verification.
    • Polaris test suite has passed

fixes #172, fixes #173

@philipwjones philipwjones requested a review from xylar December 3, 2024 18:22
@philipwjones philipwjones self-assigned this Dec 3, 2024
@xylar
Copy link

xylar commented Dec 3, 2024

Thanks very much for getting to this so quickly, @philipwjones! At a glance, it looks very good. I'll test it out tomorrow in Poalris.

Copy link

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philipwjones, this is great!

I did a merge with develop (and did my best to resolve the resulting conflict).

I then tested this with the Polaris branches I have in progress to make use of this:
E3SM-Project/polaris#231
E3SM-Project/polaris#249
E3SM-Project/polaris#242

Neither manufactured solution nor cosine bell are working quite right yet but the mechanics are finally all in place. With this PR, I am now able to translate both dimension and variable names between MPAS-Ocean and Omega conventions, perform forward runs with both models, translate the dimensions and variables back, and perform analysis and visualization (which then shows that we still have some work to do!).

I performed my tests on Chrysalis with Intel.

…s in input

   - adds support for new dimension names during Decomp reads
   - skips reading of unused dimensions in input files
   - suppresses error/warning messages at the base IO level for missing
     variables or dimensions. The calling routine now determines
     the appropriate action when missing variables are encountered.
     This eliminates warnings for harmless situations that can cause
     confusion and unnecessary output in the log file.
@philipwjones philipwjones merged commit 399b7af into E3SM-Project:develop Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omega tries to read NTracers from input file Inconsistent expectations about dimension names
2 participants