-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new RRSwISC6to18E3r5 ocean and sea-ice mesh #6447
Conversation
The new ones use a 64-bit build of gpmetis that does not leave partitions with zero cells.
@jonbob, this is ready for you to update namelist options based on what actually worked in your simulations. |
@cbegeman, @erinethomas, @proteanplanet and @vanroekel, could you provide details of any relevant review you have performed of the mesh and simulations in the review page linked above and approve when you are ready here? @jonbob, could you provide links to the simulation page(s) and relevant analysis here and on the review page when you can? |
@vanroekel, that's what I meant above by this:
|
Oh goodness, sorry for missing the obvious @xylar |
No worries! |
Simulation page for a 23+ year run with this mesh is here: 20240426.HRr5_5-G.chrysalis |
Can we start merging this? I'd like to get it on master so we can start testing hi-res (just needs to run for a couple of days). |
@cbegeman @vanroekel @proteanplanet @erinethomas can one of you approve this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for mesh quality as indicated in analysis posted at https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4219863057/Review+RRSwISC6to18E3r5.
@rljacob, new meshes are a big, big deal. We really need all to approve. |
@vanroekel and @cbegeman, it looks like you have approved in the confluence document. Can you approve here as well. @erinethomas, could you approve both places, let us know if you need more time, or let us know if you would rather not review? |
@jonbob, the conflict in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of mesh analysis in several G-cases and the necessity of increasing minimum water column thickness from analysis of previous meshes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved by visual inspection and from extensive evaluation of several G-cases by myself and others.
I haven't had a chance to review any of this yet - I will have a review complete by the end of the day. |
Thank you, @erinethomas! And thanks @vanroekel, @proteanplanet and @cbegeman for reviewing! |
Thanks @xylar -- if it looks trivial, I'm happy to take care of it when I merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to find enough time today to go through a detailed review with my own tools, however, given the time limits, I approve this mesh based upon a review of all the mesh figures posted here: https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4219863057/Review+RRSwISC6to18E3r5.
Add new RRSwISC6to18E3r5 ocean and sea-ice mesh Long name: RRSwISC6to18L80E3SMv3r5 This RRS (Rossby-radius scaled) mesh has: * 6 km resolution near the poles * 18 km resolution at the equator This is a proposed E3SM v3 (E3) high resolution (near-eddy-resolving) mesh. This is revision 5 (r5) of the mesh, which includes a flood fill of the land-ice mask to ensure correct connectivity (MPAS-Dev/compass#800). The minimum water-column thickness has been set to 20 m. [BFB] for all currently tested configurations
all new files staged on the inputdata repo passes:
merged to next |
merged to master |
Woohoo! Thanks to everyone involved in making support for this mesh, initial condition and the simulations with it possible! |
Long name: RRSwISC6to18L80E3SMv3r5
This RRS (Rossby-radius scaled) mesh has:
This is a proposed E3SM v3 (E3) high resolution (near-eddy-resolving) mesh. This is revision 5 (r5) of the mesh, which includes a flood fill of the land-ice mask to ensure correct connectivity (MPAS-Dev/compass#800). The minimum water-column thickness has been set to 20 m. These are the primary differences compared with #6143.
The mesh was created using compass, specifically this PR:
MPAS-Dev/compass#801
A compass tag will be created for the mesh as soon as the PR is merged.
The mesh and forthcoming simulation results will be reviewed here:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4219863057/Review+RRSwISC6to18E3r5
G- and B-case simulations will begin shortly and analysis will be posted here and on the review page as soon as it is available.
Relevant discussion of this mesh can be found here:
E3SM-Ocean-Discussion#86
[BFB] for all currently tested configurations