Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update circleci image spec due to upstream changes #6277

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Mar 4, 2024

Addresses CircleCI new image requirements, lest we are affected by brownouts and eventual blackouts.

--

We expreienced our first brownout in https://app.circleci.com/pipelines/github/E3SM-Project/E3SM/10529/workflows/8d2afe3d-53a7-456d-ae39-ecf6378f23f9/jobs/10059 (as part of PR #6276). See the note by CircleCI here: https://discuss.circleci.com/t/linux-image-deprecations-and-eol-for-2024/50177. The fix in this PR is simply putting a band-aid on our CircleCI testing until we have some time for a proper fix and for a thorough upgrade of our containers.

Copy link

github-actions bot commented Mar 4, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6277/
on branch gh-pages at 2024-03-04 01:42 UTC

@rljacob
Copy link
Member

rljacob commented Mar 4, 2024

We can probably get rid of circle ci and replace it with a github action. Its doing a build-only test of a fully coupled case. The command to do that is:
./create_test --no-run SMS.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850

@mahf708
Copy link
Contributor Author

mahf708 commented Mar 4, 2024

Hi @rljacob, I agree, I just didn't want to be the one proposing the change :)

I went ahead and implemented a fix that will allow us to avoid their planned brownouts and blackouts, but we can drop this PR and/or simply get rid of our CircleCI runs.

I was hoping to propose getting rid of CircleCI testing once I manage to upgrade our images from 20.04 to 22.04 (see this PR: mahf708/e3sm-imgs#13, I just didn't have enough time to test changes locally, but I am hoping it will be a quick work once I get to it)

@mahf708
Copy link
Contributor Author

mahf708 commented Mar 4, 2024

Also, note that this PR was in response to us experiencing a brownout in PR #6276 (see my note on top: #6277 (comment))

@mahf708 mahf708 marked this pull request as ready for review March 4, 2024 14:56
@mahf708 mahf708 requested a review from rljacob March 4, 2024 14:56
@mahf708 mahf708 added the Testing Anything related to unit/system tests label Mar 4, 2024
@mahf708 mahf708 changed the title fix circleci image spec due to upstream changes upate circleci image spec due to upstream changes Mar 4, 2024
@rljacob rljacob self-assigned this Mar 4, 2024
@mahf708 mahf708 changed the title upate circleci image spec due to upstream changes update circleci image spec due to upstream changes Mar 4, 2024
@rljacob rljacob merged commit 1b07f7f into master Mar 6, 2024
11 checks passed
@rljacob rljacob deleted the mahf708/idp/fix-circleci-img branch March 6, 2024 01:54
@rljacob rljacob added the BFB PR leaves answers BFB label Mar 6, 2024
rljacob added a commit that referenced this pull request Mar 6, 2024
Addresses CircleCI new image requirements, lest we are affected by brownouts and eventual blackouts.

[BFB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB Testing Anything related to unit/system tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants