fates api 33 compatibility, two-stream radiation #6279
Conversation
Enable the host land model to input and interpolate raw land use harmonization data (LUH2) states and transitions to be passed to FATES.
|
This is based off of https://github.com/glemieux/E3SM/tree/lnd/fates-luh2 which is coming in via #5760 |
|
Not sure why the circleci build fails, I ran a test on perlmutter and it worked fine: I'll go ahead run the land developer test suite and report in. @glemieux and I also have to decide on new tests, if any to add in with this. |
|
To do list (assigned to me):
|
|
Kicking off |
These variables were removed with API33
|
Regression testing with |
|
@glemieux @peterdschwartz is this ready to merge? |
|
@rljacob If the code changes are done, then it would at least need a review from @bishtgautam |
|
@rljacob , I believe it is, removing the label |
| ncgen -o $FATESPARAMFILE $FATESDIR/parameter_files/fates_params_default.cdl | ||
|
|
||
| $FATESDIR/tools/modify_fates_paramfile.py --O --fin $FATESPARAMFILE --fout $FATESPARAMFILE --var fates_rad_model --val 2 --allpfts |
There was a problem hiding this comment.
Why is the parameter file generated on the fly by ncgen and then modified, instead of having the file added to the inutdeck server?
There was a problem hiding this comment.
We update the parameter file frequently in FATES. This prevents us from having to make changes to multiple test files every time we change an irrelevant parameter (which would also be a liability to injecting bugs.. ie what if we don't update all the files correctly every time there is a change).
Note that in the future, it is intended that we will have many of these on-the-fly parameter files generated, so that we can stress test the model with many different configurations. It would not be a matter of updating 1 or two files, but think more like 5-10.
| call set_fates_ctrlparms('use_lu_harvest',ival=pass_lu_harvest) | ||
| call set_fates_ctrlparms('num_lu_harvest_cats',ival=pass_num_lu_harvest_types) | ||
| call set_fates_ctrlparms('use_logging',ival=pass_logging) | ||
|
|
||
| if(use_fates_luh) then |
There was a problem hiding this comment.
Please add a whitespace if(use_fates_luh) then --> if (use_fates_luh) then
There was a problem hiding this comment.
added white-space via 801afee
Apologies for the delayed response. I'm currently rerunning tests after correcting an issue (via 468157c) with the |
…#6279) This set of changes enables compatibility with FATES API 33, which brings in two-stream radiation for vegetation canopies. [non-BFB] for FATES
|
merged to next |
This set of changes enables compatibility with FATES API 33, which brings in two-stream radiation for vegetation canopies.