Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define new GMPAS, GPMAS, ECO compsets with JRA #6262

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

maltrud
Copy link
Contributor

@maltrud maltrud commented Feb 26, 2024

Define new compset aliases that support marine BGC using JRA1.4 forcing. Also allow GPMPAS configurations (with active ELM and MOSART) to work with WC14to60E2r3, EC30to60E2r2, and ARRM10to60E2r1 grids.

Fixes #6209

Fixes #6208

[BFB]

@maltrud maltrud added enhancement compset BFB PR leaves answers BFB BGC labels Feb 26, 2024
@maltrud maltrud requested a review from jonbob February 26, 2024 18:02
Copy link

github-actions bot commented Feb 26, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6262/
on branch gh-pages at 2024-04-11 21:02 UTC

@rljacob
Copy link
Member

rljacob commented Mar 21, 2024

notes: Jon will work on. Depends on conversation on supporting lots of compsets in bgc.

@jonbob
Copy link
Contributor

jonbob commented Mar 27, 2024

@maltrud -- is there a reason to add aliases for all three flavors of JRA forcing? I think there will be a push for us to have more like representative compset aliases with the understanding that a more full list is accessible through compset long-names. Of course, it's also fine to just merge this as-is and think about changing which ones we keep in a later compset alias reduction PR

@maltrud
Copy link
Contributor Author

maltrud commented Apr 10, 2024

@jonbob yes I'm fine with reducing the number of compsets with aliases--it is already getting out of hand. just one flavor of JRA, and also (maybe?) no need for OECO.

@jonbob
Copy link
Contributor

jonbob commented Apr 11, 2024

@maltrud -- OK, I just left the JRA1p4 versions of the new compsets, since JRA1p5 has issues right now. We can update that later if it becomes preferable

Copy link
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that all new files are available on the inputdata repo, and passes sanity testing.

jonbob added a commit that referenced this pull request Apr 11, 2024
…(PR #6262)

Define new GMPAS, GPMAS, ECO compsets with JRA

Define new compset aliases that support marine BGC using JRA1.4 forcing.
Also allow GPMPAS configurations (with active ELM and MOSART) to work
with WC14to60E2r3, EC30to60E2r2, and ARRM10to60E2r1 grids.

Fixes #6209
Fixes #6208

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Apr 11, 2024

merged to next

@rljacob
Copy link
Member

rljacob commented Apr 12, 2024

Are all the files in the right flavor of NetCDF?

@jonbob
Copy link
Contributor

jonbob commented Apr 12, 2024

@rljacob -- I'll double-check that and fix them if not

@jonbob jonbob merged commit cf3e0c0 into master Apr 12, 2024
11 checks passed
@jonbob jonbob deleted the maltrud/ocean/add-G-and-GP-and-ECO-compsets branch April 12, 2024 18:34
@jonbob
Copy link
Contributor

jonbob commented Apr 12, 2024

Thanks @rljacob -- good catch. They're converted and checked on the inputdata server as well as the local lcrc inputdata location.

merged to master

xylar added a commit to xylar/compass that referenced this pull request May 8, 2024
This merge updates the E3SM-Project submodule from [93e511d](https://github.com/E3SM-Project/E3SM/tree/93e511d) to [31e0924](https://github.com/E3SM-Project/E3SM/tree/31e0924).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#6256
- [ ]  (ocn) E3SM-Project/E3SM#6224
- [ ]  (ocn) E3SM-Project/E3SM#6270
- [ ]  (ocn) E3SM-Project/E3SM#6293
- [ ]  (ocn) E3SM-Project/E3SM#6321
- [ ]  (ocn) E3SM-Project/E3SM#6262
- [ ]  (ocn) E3SM-Project/E3SM#6300
- [ ]  (ocn) E3SM-Project/E3SM#6334
- [ ]  (ocn) E3SM-Project/E3SM#6371
- [ ]  (ocn) E3SM-Project/E3SM#6288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants