Add new IcoswISC30E3r2 ocean and sea-ice mesh #5931

xylar · 2023-09-18T20:30:30Z

Long name: IcoswISC30L64E3SMv3r2

This Icosahedral (Icos) mesh is made by subdividing an icosahedron and has nearly uniform 30 km resolution.

This mesh is a candidate for the E3SM v3 (E3) low res mesh. It is revision 2 (r2) of the mesh. (Revision 1 had incorrect bathymetry and coastline around Greenland.)

The mesh was created using compass, specifically this tag: https://github.com/MPAS-Dev/compass/releases/tag/mesh_IcoswISC30E3r2

A G-case with data iceberg melt fluxes (DIB) and data ice-shelf melt fluxes (DISMF) has been run for 30 years, with MPAS-Analysis output available here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/20230905.G-test.IcoswISC30E3r2.anvil/

The mesh and the G-case results is still been reviewed and approved here:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/3904831507/Review+IcoswISC30E3r2

A B-case will begin shortly and analysis will be posted here and on the review page as soon as it is available.

xylar · 2023-09-18T20:31:07Z

This branch is based off of #5927 and will be rebased after that PR is merged.

xylar · 2023-09-18T20:33:43Z

Relevant discussion at E3SM-Ocean-Discussion#64

xylar · 2023-09-18T20:36:41Z

@jonbob, what about these files? Should I sync over the inputdata and diagnostics files for these, too?

mark-petersen

Reviewed mesh, coastlines, critical passages, and MPAS-Analysis simulation results.

proteanplanet

Through-flow, shallow bathymetry, cavity geometry and coastlines have been checked.

erinethomas

approved - looked at MPAS-analysis and mesh.

rljacob · 2023-09-22T01:44:24Z

cime_config/config_grids.xml

+    <gridmap atm_grid="ne30np4.pg2" ocn_grid="ECwISC30to60E3r2">
+      <map name="ATM2OCN_FMAPNAME">cpl/gridmaps/ne30pg2/map_ne30pg2_to_ECwISC30to60E3r2_mono.230901.nc</map>
+      <map name="ATM2OCN_VMAPNAME">cpl/gridmaps/ne30pg2/map_ne30pg2_to_ECwISC30to60E3r2_bilin.230901.nc</map>
+      <map name="ATM2OCN_SMAPNAME">cpl/gridmaps/ne30pg2/map_ne30pg2_to_ECwISC30to60E3r2-nomask_bilin.230901.nc</map>


Was this made with TempestRemap?

@jonbob, that's a question for you.

We've been making all conservative "mono" mapping files with tempest, but not the bilinear ones. I'll try to change the process to match the new naming convention and process

jonbob · 2023-09-26T18:26:10Z

20-year B-case using the CRYO1850 compset has completed:
MPAS-Analysis for: 20230918.test5931.anvil

rljacob

Bilinear maps need to be remade with TR. Map files need to be renamed to follow naming convention.

jonbob · 2023-11-14T19:56:12Z

The new mapping and domain files have been staged to /lcrc/group/e3sm/data/inputdata and have been tested successfully with:

SMS_Ld3.T62_IcoswISC30E3r2.CMPASO-IAF.chrysalis_intel
SMS_Ld3.TL319_IcoswISC30E3r2.GMPAS-JRA1p5.chrysalis_intel
SMS_Ld3.ne30pg2_IcoswISC30E3r2.WCYCL1850.chrysalis_intel
SMS_Ld3.ne30pg2_r05_IcoswISC30E3r2.WCYCL1850.chrysalis_intel
SMS_Ld3.ne30pg2_r05_IcoswISC30E3r2.WCYCL1850.chrysalis_intel with trfvnp2 mapping file

jonbob · 2023-11-14T20:00:40Z

@rljacob -- can you check that the mapping files are now consistent with the algorithm and naming conventions?

cime_config/config_grids.xml

xylar · 2023-11-14T20:23:15Z

@jonbob, please verify that the grid files look correct after the rebase. I don't expect any problems.

@rljacob, could you verify that your concerns have been addressed by @jonbob's latest commit?

xylar · 2023-11-14T20:24:03Z

@alicebarthel, could you either approve or let us know if you have concerns about this mesh?

jonbob · 2023-11-14T21:20:31Z

@xylar -- thanks for rebasing. The grid files looked good to me from a visual inspection, and I ran a quick ne30pg2_r05_IcoswISC30E3r2.WCYCL1850 smoke test to check -- and it has been successful as well

rljacob · 2023-11-15T23:47:37Z

cime_config/config_grids.xml

+    <gridmap atm_grid="T62" ocn_grid="IcoswISC30E3r2">
+      <map name="ATM2OCN_FMAPNAME">cpl/gridmaps/T62/map_T62_to_IcoswISC30E3r2_traave.20231113.nc</map>
+      <map name="ATM2OCN_SMAPNAME">cpl/gridmaps/T62/map_T62_to_IcoswISC30E3r2-nomask_trbilin.20231113.nc</map>
+      <map name="ATM2OCN_VMAPNAME">cpl/gridmaps/T62/map_T62_to_IcoswISC30E3r2_patch.20231113.nc</map>


"patch" should be "esmfpatch"

It should be fixed now

rljacob · 2023-11-15T23:48:02Z

cime_config/config_grids.xml

+    <gridmap atm_grid="TL319" ocn_grid="IcoswISC30E3r2">
+      <map name="ATM2OCN_FMAPNAME">cpl/gridmaps/TL319/map_TL319_to_IcoswISC30E3r2_traave.20231113.nc</map>
+      <map name="ATM2OCN_SMAPNAME">cpl/gridmaps/TL319/map_TL319_to_IcoswISC30E3r2-nomask_trbilin.20231113.nc</map>
+      <map name="ATM2OCN_VMAPNAME">cpl/gridmaps/TL319/map_TL319_to_IcoswISC30E3r2_patch.20231113.nc</map>


"patch" should be "esmfpatch"

should be fixed now

rljacob · 2023-11-15T23:51:27Z

cime_config/config_grids.xml

@@ -4540,6 +4638,11 @@
      <map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_rx1_to_ECwISC30to60E3r2_smoothed.r150e300.230901.nc</map>
    </gridmap>

+    <gridmap ocn_grid="IcoswISC30E3r2" rof_grid="rx1">
+      <map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_rx1_to_IcoswISC30E3r2_smoothed.r150e300.230905.nc</map>


"smoothed" should be "cstmnn" for "custom nearest neighbor".

should be fixed now -- I also changed the datestamp to YYYYMMDD to match the new naming convention

rljacob · 2023-11-15T23:51:42Z

cime_config/config_grids.xml

@@ -4540,6 +4638,11 @@
      <map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_rx1_to_ECwISC30to60E3r2_smoothed.r150e300.230901.nc</map>
    </gridmap>

+    <gridmap ocn_grid="IcoswISC30E3r2" rof_grid="rx1">
+      <map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_rx1_to_IcoswISC30E3r2_smoothed.r150e300.230905.nc</map>
+      <map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_rx1_to_IcoswISC30E3r2_smoothed.r150e300.230905.nc</map>


"smoothed" should be "cstmnn"

rljacob · 2023-11-15T23:52:22Z

cime_config/config_grids.xml

@@ -4600,6 +4703,11 @@
      <map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_JRA025_to_ECwISC30to60E3r2_smoothed.r150e300.230901.nc</map>
    </gridmap>

+    <gridmap ocn_grid="IcoswISC30E3r2" rof_grid="JRA025">
+      <map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_JRA025_to_IcoswISC30E3r2_smoothed.r150e300.230905.nc</map>
+      <map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_JRA025_to_IcoswISC30E3r2_smoothed.r150e300.230905.nc</map>


smoothed should be "cstmnn" for both.

rljacob · 2023-11-15T23:52:37Z

cime_config/config_grids.xml

@@ -4685,6 +4793,11 @@
      <map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_r05_to_ECwISC30to60E3r2_smoothed.r150e300.230901.nc</map>
    </gridmap>

+    <gridmap ocn_grid="IcoswISC30E3r2" rof_grid="r05">
+      <map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_r05_to_IcoswISC30E3r2_smoothed.r150e300.230905.nc</map>
+      <map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_r05_to_IcoswISC30E3r2_smoothed.r150e300.230905.nc</map>


"smoothed" should be "cstmnn" for both.

rljacob · 2023-11-15T23:56:43Z

The r2o maps need a name fix but the rest look good. Also make sure these are on the input data server.

mark-petersen · 2023-11-16T15:03:59Z

components/mpas-ocean/bld/namelist_files/namelist_defaults_mpaso.xml

@@ -476,6 +491,7 @@
 <config_btr_dt ocn_grid="SOwISC12to60E2r4">'0000_00:00:15'</config_btr_dt>
 <config_btr_dt ocn_grid="ECwISC30to60E2r1">'0000_00:01:00'</config_btr_dt>
 <config_btr_dt ocn_grid="ECwISC30to60E3r2">'0000_00:01:00'</config_btr_dt>
+<config_btr_dt ocn_grid="IcoswISC30E3r2">'0000_00:00:45'</config_btr_dt>


(documenting a slack conversation) This icos ~30km should be able to run with exactly the same time step settings as the EC30to60, since it only depends on the minimum cell width. That means

<config_dt ocn_grid="IcoswISC30E3r2">'00:30:00'</config_dt> (it's already set to that) <config_btr_dt ocn_grid="IcoswISC30E3r2">'0000_00:01:15'</config_btr_dt>

The 45s was overly cautious to begin with. 1:15 should work.

@mark-petersen -- in testing 1:15 caused mpaso state validation errors, but 1:00 has been stable

OK, thanks. The barotropic time step is limited by an advective CFL condition for the surface gravity waves. There must be some faster velocities on the ICOS30 in locations with 30km cells, where the EC30to60 has larger cells (like mid-latitude western boundary currents). Regardless, we always set this by trial and error in the end. Thanks for testing it. The 1:00 is still a big improvement over 45s.

jonbob · 2023-11-16T21:29:43Z

@rljacob -- I think I fixed all the naming issues, and changed the filenames on the lcrc local inputdata location. Once you approve, I'll copy them to the inputdata server

alicebarthel

I approve based on visual inspection of the mesh plots and the G- and B-case MPAS-Analysis plots. Some enhanced biases due to coupling but nothing that look outside of our normal range of issues, or would warrant blocking this configuration in my opinion. Well done!

xylar · 2023-11-20T00:54:52Z

I'm putting this in draft mode because I just discovered a bug in landIceMask (which affects the initial condition as well as several mapping files) over the weekend.

MPAS-Dev/compass#732

xylar · 2023-11-20T16:58:57Z

I'm closing this and will make a new PR for IcoswISC30E3r4 with the bug fix and topography smoothing.

xylar added mpas-ocean mpas-seaice BFB PR leaves answers BFB labels Sep 18, 2023

xylar requested review from darincomeau, mark-petersen, proteanplanet, alicebarthel and erinethomas September 18, 2023 20:30

xylar assigned jonbob Sep 18, 2023

xylar changed the title ~~Add new ECwISC30to60E3r2 ocean and sea-ice mesh~~ Add new IcoswISC30E3r2 ocean and sea-ice mesh Sep 18, 2023

xylar mentioned this pull request Sep 18, 2023

Add new IcoswISC30E3r2 mesh E3SM-Ocean-Discussion/E3SM#64

Closed

mark-petersen approved these changes Sep 19, 2023

View reviewed changes

proteanplanet approved these changes Sep 20, 2023

View reviewed changes

erinethomas approved these changes Sep 21, 2023

View reviewed changes

rljacob reviewed Sep 22, 2023

View reviewed changes

darincomeau approved these changes Oct 4, 2023

View reviewed changes

rljacob added this to the v3.0alpha05 milestone Oct 12, 2023

rljacob requested changes Nov 14, 2023

View reviewed changes

rljacob mentioned this pull request Nov 14, 2023

Change bilinear map for low-res coupled case to use TempestRemap #5922

Closed

xylar and others added 5 commits November 14, 2023 13:10

Add IcoswISC30E3r2 to MPAS-Ocean

d6cf931

Add IcoswISC30E3r2 to MPAS-Seaice

46513ca

Add IcoswISC30E3r2 to ELM

9c7929c

Add IcoswISC30E3r2 mapping and domain files

1bcf111

Add ocn/ice spunup ICs from 1-month GMPAS-JRA1p5-DIB-DISMF test

5fdcbfb

jonbob added 3 commits November 14, 2023 13:13

Fix naming of IcoswISC30E3r2 spunup IC file

660ba21

Add support for ne30pg2_r05_IcoswISC30E3r2, ne120pg2_r05_IcoswISC30E3r2

e5af3e8

Update IcoswISC30E3r2 mapping and domain files to match new convention

f270208

xylar force-pushed the mesh/add-icoswisc30e3r2 branch from 701f92c to f270208 Compare November 14, 2023 20:16

xylar commented Nov 14, 2023

View reviewed changes

cime_config/config_grids.xml Outdated Show resolved Hide resolved

Fix description of the IcoswISC30E3r2 domain

e72ce75

rljacob reviewed Nov 15, 2023

View reviewed changes

mark-petersen reviewed Nov 16, 2023

View reviewed changes

jonbob added 2 commits November 16, 2023 14:59

Fix mapping file names to match reviewer feedback

88b4784

Increase btr_dt to 1:00, stable in testing

9f3692c

rljacob approved these changes Nov 17, 2023

View reviewed changes

alicebarthel approved these changes Nov 17, 2023

View reviewed changes

xylar marked this pull request as draft November 20, 2023 00:53

xylar closed this Nov 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new IcoswISC30E3r2 ocean and sea-ice mesh #5931

Add new IcoswISC30E3r2 ocean and sea-ice mesh #5931

xylar commented Sep 18, 2023

xylar commented Sep 18, 2023

xylar commented Sep 18, 2023

xylar commented Sep 18, 2023

mark-petersen left a comment

proteanplanet left a comment

erinethomas left a comment

rljacob Sep 22, 2023

xylar Sep 22, 2023

jonbob Sep 26, 2023

jonbob commented Sep 26, 2023

rljacob left a comment

jonbob commented Nov 14, 2023 •

edited

Loading

jonbob commented Nov 14, 2023

xylar commented Nov 14, 2023

xylar commented Nov 14, 2023

jonbob commented Nov 14, 2023

rljacob Nov 15, 2023

jonbob Nov 16, 2023

rljacob Nov 15, 2023

jonbob Nov 16, 2023

rljacob Nov 15, 2023

jonbob Nov 16, 2023

rljacob Nov 15, 2023

rljacob Nov 15, 2023

rljacob Nov 15, 2023

rljacob commented Nov 15, 2023

mark-petersen Nov 16, 2023

jonbob Nov 16, 2023

mark-petersen Nov 16, 2023

jonbob commented Nov 16, 2023

alicebarthel left a comment

xylar commented Nov 20, 2023 •

edited

Loading

xylar commented Nov 20, 2023

Add new IcoswISC30E3r2 ocean and sea-ice mesh #5931

Add new IcoswISC30E3r2 ocean and sea-ice mesh #5931

Conversation

xylar commented Sep 18, 2023

xylar commented Sep 18, 2023

xylar commented Sep 18, 2023

xylar commented Sep 18, 2023

mark-petersen left a comment

Choose a reason for hiding this comment

proteanplanet left a comment

Choose a reason for hiding this comment

erinethomas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonbob commented Sep 26, 2023

rljacob left a comment

Choose a reason for hiding this comment

jonbob commented Nov 14, 2023 • edited Loading

jonbob commented Nov 14, 2023

xylar commented Nov 14, 2023

xylar commented Nov 14, 2023

jonbob commented Nov 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rljacob commented Nov 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonbob commented Nov 16, 2023

alicebarthel left a comment

Choose a reason for hiding this comment

xylar commented Nov 20, 2023 • edited Loading

xylar commented Nov 20, 2023

jonbob commented Nov 14, 2023 •

edited

Loading

xylar commented Nov 20, 2023 •

edited

Loading