-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change bilinear map for low-res coupled case to use TempestRemap #5922
Conversation
The bilinear map used for the ne30np4.pg2 and EC30to60E2r2 grid combination is changed to one generated using TempestRemap. This will allow coupling with offline maps to better match coupling with online maps which use the same algorithm from TempestRemap to calculate the weights. [non-BFB] for cases using ne30np4.pg2 and EC30to60E2r2
To help confirm there's no significant climate change, I did 2 50-year runs. The first used the hash of master this branch started from (a pre-v3 version from July). The second run changes only the a2o states mapping file. Comparison with observations (both e3sm_diags and mpas_analysis) model-vs-model: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/jacob/E3SM/WCYCLtrbilin/e3sm_diags/atm_monthly_180x360_aave_mvm/model_vs_model_0011-0050/viewer/) |
Could this potentially change the MPI communication pattern? And have a performance impact? |
Quite unfortunate that the tests were done on pre-v3 (added the mvm to your comment). I think the results make since, especially that the surface radiation terms seem to be more influenced than the TOA terms. As far as I understand, we don't have a category for "little more then roundoff but not climate changing", but yeah, I guess that's the case here (for a 10-year case, I usually would argue that a change of RESTOM >0.05 W/m2 is my arbitrary cutoff for CC, <0.01 for non-CC, and you have 0.037...) |
Just trying it:
|
I didn't have the new file on the input data server. Its there now. There should be no significant change in performance. |
Those diffs above look like they're from internal variability. |
@rljacob -- can you run mpas-analysis as well on the two tests? |
@jonbob its available at the first two links in #5922 (comment) |
Thanks @rljacob -- I was hoping for output showing the model vs model comparison |
I wouldn't dismiss them simply like that. Do you have any supporting evidence or additional information the rest of us don't have? Any explanation for why the changes are concentrated in the polar regions? Polar amplification in the other direction? Anyway, this is largely not an atmosphere issue, so I can't really judge what's going on and how much is within an acceptable range for non-CC. |
The chk_map feature of ncks shows little difference between the mapping files: map_ne30pg2_to_EC30to60E2r2_bilin.tr.230522.nc
map_ne30pg2_to_EC30to60E2r2_bilin.201005.nc
The conservation and consistency metrics are very close as well: map_ne30pg2_to_EC30to60E2r2_bilin.tr.230522.nc
map_ne30pg2_to_EC30to60E2r2_bilin.201005.nc
|
@rljacob -- I can run the mpas-analysis comparison if you want |
@jonbob thanks for posting the nco stats. Yes please run the mpas-analysis comparison. It will take me a while to figure out how to do it. |
Model-to-model comparison with MPAS-Analysis is at MPAS-Analysis output for: WCYCLtrbilin |
i think I'll do some F-case runs. They'll show a change because the a2o results are used in the ocean-atmosphere flux calculation. But there'll be less internal variability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The differences in results look on the order of what we expect as ensemble-member level, and the ncks output makes these mapping files look similar in precision as those made with esmf.
@rljacob did you end up running F2010 cases? If not, do you want me to run something for you? (assuming you still want them...) |
This PR has minimal effect on aerosol ERF (table below in W/m2). This test is also a potential data point for assessing how CC this PR is. This PR is not CC, as Jon has already indicated.
(If you add the numbers above, they don't conserve; that's because there's a term left out --- it is a residual term to do with the surface (mostly) and it makes sense it's carrying most of the changes here.) |
@mahf708 No I haven't run any F-cases yet. Any runs you do are appreciated. |
Hi Rob, I did two quick (15-month F2010 nudged) runs and reported their results above. I think this PR is in "round-off" territory (like you and Jon already indicated) from the perspective of forcing I care about. It is difficult to examine any weird feedback coming from this PR, but I would bet it is relatively small compared to other things going on. I could/would proceed to performing some 11-year F2010 runs, but I doubt we will learn much more from them... |
The nnz in the TempestRemap bilinear map is about the same (but not exactly the same as ESMF bilinear map). But I do not expect any sort of significant bump in parallel performance, if at all. @ndkeen |
The bilinear map used for the ne30np4.pg2 and EC30to60E2r2 grid combination (and only for mapping atmosphere states to the ocean mesh) is changed to one generated using TempestRemap. This will allow coupling with offline maps to better match coupling with online maps which use the same algorithm from TempestRemap to calculate the weights.
The answer changes are a little more then roundoff but not climate changing.
[non-BFB] for cases using ne30np4.pg2 and EC30to60E2r2