-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FATES cross-grid seed dispersal mechanism #5555
Add FATES cross-grid seed dispersal mechanism #5555
Conversation
@glemieux Did you forget to update the FATES submodule? |
Btw, this is a very exciting PR and I'm interested to find out the approach you and the FATES team took for this work. |
I was going to push the final update once we've integrated NGEET/fates#1005 so I can point to the specific fates |
@bishtgautam FYI I also have a new parameter file to be uploaded per NGEET/fates#1005. |
I'll be happy to upload the new parameter file on the inputdata server. |
status: waiting on a corresponding FATES PR. |
status: still waiting on a FATES PR. |
@bishtgautam this will need to come in after the API25.5 update in #5802. |
845ddfe
to
caa28fc
Compare
notes: should be done soon. FATES-side tests are progressing. |
Waiting on #5849 |
@peterdschwartz now that #5849 is merged, we can start moving forward with this again. I'm working on an ERS fix on the fates-side that accompanies this, but that should be done in the next day or so. After that I'll rebase and retest this. |
a10cb70
to
1ee8fc5
Compare
status: working on an exact restart issue. |
@glemieux any update on restart issue? |
update: currently being worked on. |
6254938
to
9a52441
Compare
Regression testing against master on
The differences in the fates testmod are expected as this PR includes a number of known answer changing scientific updates for fates science. The non-fates test is only showing DIFFs in the Location on perlmutter: Regression test results for |
The There is also a fates test that is not passing exart restart, but this is expected (see NGEET/fates#1106) and will be corrected in a forthcoming PR. Location on perlmutter: |
Testing with NGEET/fates#1109 in progress to address known ERS issue. |
Looking at a restart issue on FATES side. Otherwise ready. |
3ab4f6a
to
e7921a0
Compare
@peterdschwartz FATES restart issue has been resolved via e7921a0. I rebased against |
@peterdschwartz this is finally all good to go. Regression tests on perlmutter are coming back B4B with the known exception of the Regression test results: |
…sal' into next (PR #5555) This PR enables FATES to disperse seeds across neighboring grid cells using MPI. The API update includes calls to new fates dispersal procedures and as such should be coordinated with NGEET/fates#1005. [B4B] except for FATES
merged to next |
This PR enables FATES to disperse seeds across neighboring grid cells using MPI. The API update includes calls to new fates dispersal procedures and as such should be coordinated with NGEET/fates#1005.
[B4B] except for FATES