Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FATES cross-grid seed dispersal mechanism #5555

Merged

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Mar 24, 2023

This PR enables FATES to disperse seeds across neighboring grid cells using MPI. The API update includes calls to new fates dispersal procedures and as such should be coordinated with NGEET/fates#1005.

[B4B] except for FATES

@bishtgautam
Copy link
Contributor

@glemieux Did you forget to update the FATES submodule?

@bishtgautam
Copy link
Contributor

Btw, this is a very exciting PR and I'm interested to find out the approach you and the FATES team took for this work.

@glemieux
Copy link
Contributor Author

@glemieux Did you forget to update the FATES submodule?

I was going to push the final update once we've integrated NGEET/fates#1005 so I can point to the specific fates main commit. For now I was planning on only updating locally when I run the land developer tests. I'm more than happy to push that interim update though.

@glemieux
Copy link
Contributor Author

glemieux commented Mar 24, 2023

@bishtgautam FYI I also have a new parameter file to be uploaded per NGEET/fates#1005.

@bishtgautam
Copy link
Contributor

I'll be happy to upload the new parameter file on the inputdata server.

@rljacob
Copy link
Member

rljacob commented Apr 6, 2023

status: waiting on a corresponding FATES PR.

@rljacob
Copy link
Member

rljacob commented Jul 6, 2023

status: still waiting on a FATES PR.

@glemieux
Copy link
Contributor Author

@bishtgautam this will need to come in after the API25.5 update in #5802.

@glemieux glemieux force-pushed the lnd/fates-crossgrid-seeddispersal branch 2 times, most recently from 845ddfe to caa28fc Compare July 24, 2023 21:47
@rljacob
Copy link
Member

rljacob commented Jul 27, 2023

notes: should be done soon. FATES-side tests are progressing.

@rljacob
Copy link
Member

rljacob commented Aug 10, 2023

Waiting on #5849

@glemieux
Copy link
Contributor Author

@peterdschwartz now that #5849 is merged, we can start moving forward with this again. I'm working on an ERS fix on the fates-side that accompanies this, but that should be done in the next day or so. After that I'll rebase and retest this.

@glemieux glemieux force-pushed the lnd/fates-crossgrid-seeddispersal branch from a10cb70 to 1ee8fc5 Compare September 1, 2023 22:17
@rljacob
Copy link
Member

rljacob commented Sep 7, 2023

status: working on an exact restart issue.

@rljacob
Copy link
Member

rljacob commented Sep 21, 2023

@glemieux any update on restart issue?

@glemieux
Copy link
Contributor Author

@glemieux any update on restart issue?

@rljacob There is an issue with the PEM and ERP for this. The current plan is to make this a known issue and integrate into fates main/hlm master branches and address this later.

@rljacob
Copy link
Member

rljacob commented Oct 12, 2023

update: currently being worked on.

@glemieux glemieux force-pushed the lnd/fates-crossgrid-seeddispersal branch 4 times, most recently from 6254938 to 9a52441 Compare October 24, 2023 18:51
@glemieux
Copy link
Contributor Author

glemieux commented Oct 24, 2023

Regression testing against master on pm-cpu is in progress. The e3sm_land_debug tests are complete and coming back as b4b against master with two exceptions:

  • SMS_Ld20_D.f45_f45.IELMFATES.pm-cpu_gnu.elm-fates_rd
  • ERS_D.ne11_oQU240.I20TRELM.pm-cpu_gnu

The differences in the fates testmod are expected as this PR includes a number of known answer changing scientific updates for fates science. The non-fates test is only showing DIFFs in the cpl. @peterdschwartz is this expected?

Location on perlmutter: /pscratch/sd/g/glemieux/e3sm-tests/pr5555-eld-debug.fates.pm-cpu.gnu.C9a524415e4-F1d18bb69.DEBUG

Regression test results for e3sm_land_developer suite is forthcoming.

@glemieux
Copy link
Contributor Author

glemieux commented Oct 25, 2023

The e3sm_land_developer regression tests are complete and showing similar results to the debug tests. Nearly everything is b4b except for the fates testmods, which is as expeced, and the ERS_D.ne11_oQU240.I20TRELM.pm-cpu_gnu testmod is again coming back with a DIFF against the master baseline.

There is also a fates test that is not passing exart restart, but this is expected (see NGEET/fates#1106) and will be corrected in a forthcoming PR.

Location on perlmutter: /pscratch/sd/g/glemieux/e3sm-tests/pr5555-eld-nodebug.fates.pm-cpu.gnu.C9a524415e4-F1d18bb69

@glemieux
Copy link
Contributor Author

glemieux commented Oct 27, 2023

Testing with NGEET/fates#1109 in progress to address known ERS issue.

@rljacob
Copy link
Member

rljacob commented Nov 2, 2023

Looking at a restart issue on FATES side. Otherwise ready.

@glemieux glemieux force-pushed the lnd/fates-crossgrid-seeddispersal branch from 3ab4f6a to e7921a0 Compare November 6, 2023 22:13
@glemieux
Copy link
Contributor Author

glemieux commented Nov 6, 2023

@peterdschwartz FATES restart issue has been resolved via e7921a0. I rebased against master and I'm rerunning e3sm_land_developer regression tests on perlmutter.

@glemieux
Copy link
Contributor Author

glemieux commented Nov 8, 2023

@peterdschwartz this is finally all good to go. Regression tests on perlmutter are coming back B4B with the known exception of the fates testmods.

Regression test results: /global/homes/g/glemieux/scratch/e3sm-tests/pr5555-pr1114-eld-intel.fates.pm-cpu..Ce7921a0c0d-F1874511a

peterdschwartz added a commit that referenced this pull request Nov 16, 2023
…sal' into next (PR #5555)

This PR enables FATES to disperse seeds across neighboring grid cells using MPI.
The API update includes calls to new fates dispersal procedures and as such should be coordinated with NGEET/fates#1005.

[B4B] except for FATES
@peterdschwartz
Copy link
Contributor

merged to next

@peterdschwartz peterdschwartz merged commit 93ab10c into E3SM-Project:master Nov 20, 2023
2 checks passed
@glemieux glemieux deleted the lnd/fates-crossgrid-seeddispersal branch January 23, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants